Sign upLogin

feeedback/twitch_chat_bot_aligulac

View on GitHub
Star

Showing 15 of 15 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const getEachOtherHistory = () => {
    const rowEachOtherHistory = getRowScoreEachOther(table);
    if (rowEachOtherHistory) {
      const p1EachOtherHistory = getOnlyIntPercent(getLeftTrPart(rowEachOtherHistory).split(/[()]/)[1]);
      const p2EachOtherHistory = getOnlyIntPercent(getRightTrPart(rowEachOtherHistory).split(/[()]/)[1]);
Severity: Major
Found in api/aligulac/parse_dom.js and 1 other location - About 3 hrs to fix
api/aligulac/parse_dom.js on lines 34..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const getFormOpRace = () => {
    const rowFormOpRace = getRowFormOpRace(table);
    if (rowFormOpRace) {
      const p1FormOpRace = getOnlyIntPercent(getLeftTrPart(rowFormOpRace).split(/[()]/)[1]);
      const p2FormOpRace = getOnlyIntPercent(getRightTrPart(rowFormOpRace).split(/[()]/)[1]);
Severity: Major
Found in api/aligulac/parse_dom.js and 1 other location - About 3 hrs to fix
api/aligulac/parse_dom.js on lines 45..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function botRun has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const botRun = async (client, apiAligulac, COMMAND_CHECK_FN, botInfoMessage, db) => {
  await client.connect();
  console.log(`Бот запущен`);

  const requestFnChat = createRequestFnChat(client);
Severity: Major
Found in bot/bot.js - About 2 hrs to fix

    Function getStringFromInfoPlayerHtml has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const getStringFromInfoPlayerHtml = (data) => {
  // (Cascade) SKillous [P] 19 y.o. | #29 World, #12 Non-KR, #1 RU | matches 1399 | earned $19k | form vP 57% vT 55% vZ 72%

  const document = getDOMDocument(data);
    Severity: Major
    Found in api/aligulac/parse_dom.js - About 2 hrs to fix

      File county_code.js has 253 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      const isoCountries = {
  afghanistan: 'AF',
  'aland islands': 'AX',
  albania: 'AL',
  algeria: 'DZ',
      Severity: Minor
      Found in utils/county_code.js - About 2 hrs to fix

        Function getFromCache has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

          (cache, twoKey = false) =>
  async (key, requestFn, getDataFn) => {
    const keyToCache = typeof key !== 'string' ? JSON.stringify(key) : key;
    const itemValue = cache.smartGetItem(keyToCache); // check, check ttl, renew, return
    if (itemValue) {
        Severity: Minor
        Found in bot/interface_aligulac.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getStringFromPredictionHtml has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export const getStringFromPredictionHtml = (data) => {
  // @user (Cascade) SKillous [P] 19 y.o. | #29 World, #12 Non-KR, #1 RU | matches 1399 | earned $19k | form vP·57% vT·55% vZ·72%
  const document = getDOMDocument(data);

  const getRowFormOpRace = (table) =>
        Severity: Minor
        Found in api/aligulac/parse_dom.js - About 1 hr to fix

          Function doRequestAligulac has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const doRequestAligulac = (requestFnPrediction, requestFnPlayer, requestFnChat) => {
  const firstRequest = queueAligulac.shift();

  if (!firstRequest) {
    isQueueRunningAligulac = false;
          Severity: Minor
          Found in bot/bot.js - About 1 hr to fix

            Function getStringFromInfoPlayerHtml has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

            export const getStringFromInfoPlayerHtml = (data) => {
  // (Cascade) SKillous [P] 19 y.o. | #29 World, #12 Non-KR, #1 RU | matches 1399 | earned $19k | form vP 57% vT 55% vZ 72%

  const document = getDOMDocument(data);
            Severity: Minor
            Found in api/aligulac/parse_dom.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getFromCache has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              async (key, requestFn, getDataFn) => {
    const keyToCache = typeof key !== 'string' ? JSON.stringify(key) : key;
    const itemValue = cache.smartGetItem(keyToCache); // check, check ttl, renew, return
    if (itemValue) {
      return itemValue;
            Severity: Minor
            Found in bot/interface_aligulac.js - About 1 hr to fix

              Function requestPrediction has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              const requestPrediction = (getFromCacheNickname, getFromCachePrediction) => async (p1Name, p2Name) => {
  const name1F = formatName(p1Name);
  const name2F = formatName(p2Name);
  if (name1F === name2F) {
    console.log(`EXIT => Имена игроков совпадают`);
              Severity: Minor
              Found in bot/interface_aligulac.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this function.
              Open

                      return;
              Severity: Major
              Found in bot/bot.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return;
                Severity: Major
                Found in bot/bot.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return;
                  Severity: Major
                  Found in bot/bot.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return 'Aligulac server error';
                    Severity: Major
                    Found in bot/interface_aligulac.js - About 30 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language