Sign upLogin

feelobot/gantree

View on GitHub
Star

Showing 13 of 13 total issues

Method create has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create
    "#{@requirements}
    template do 
      value :AWSTemplateFormatVersion => '2010-09-09'
      value :Description => '#{@stack_name} Master Template'
Severity: Minor
Found in lib/gantree/cfn/master.rb - About 1 hr to fix

    Method deploy has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def deploy(envs)
      @envs = envs
      check_dir_name(envs) unless @options[:force]
      return if @options[:dry_run]
      version = DeployVersion.new(@options, envs[0])
    Severity: Minor
    Found in lib/gantree/deploy.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method configuration_template has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def configuration_template
    "resource 'ConfigurationTemplate', :Type => 'AWS::ElasticBeanstalk::ConfigurationTemplate', :Properties => {
        :ApplicationName => ref('Application'),
        :SolutionStackName => '#{@docker_version}',
        :Description => 'Default Configuration Version #{@docker_version} - with SSH access',
    Severity: Minor
    Found in lib/gantree/cfn/beanstalk.rb - About 1 hr to fix

      Method build has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def build
      puts "Building..."
      
      if system("git rev-parse --short HEAD > version.txt")
        puts "Outputting short hash to version.txt"
      Severity: Minor
      Found in lib/gantree/docker.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check_credentials has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def check_credentials
      timeout = false

      url = URI.parse("http://169.254.169.254/latest/meta-data/iam/info/")
      Severity: Minor
      Found in lib/gantree/base.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method deploy has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def deploy(envs)
      @envs = envs
      check_dir_name(envs) unless @options[:force]
      return if @options[:dry_run]
      version = DeployVersion.new(@options, envs[0])
      Severity: Minor
      Found in lib/gantree/deploy.rb - About 1 hr to fix

        Method pull has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def pull
      puts "Updating wiki cached repo".colorize(:yellow)
      if File.exist?(@wiki_path)
        Dir.chdir(@wiki_path) do
          execute("git checkout master") unless execute("git branch").include?("* master")
        Severity: Minor
        Found in lib/gantree/wiki.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def run input=""
      input = "y" if  @options[:force]
      input ||= ask "Are you sure? (y|n)"
      if input == "y" || @options[:force]
        puts "Deleting stack from aws"
        Severity: Minor
        Found in lib/gantree/delete.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method commits has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def commits
      return @commits if @commits
      # Get commits for this release
      commits = git_log
      commits = commits.split("COMMIT_SEPARATOR")
        Severity: Minor
        Found in lib/gantree/release_notes.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def run
      @options[:rds_enabled] = rds_enabled? if @options[:rds] 
      print_options
      create_cfn_if_needed
      create_all_templates unless @options[:local]
        Severity: Minor
        Found in lib/gantree/create.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check_for_updates has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def self.check_for_updates opts
      puts opts.inspect
      enabled =  opts[:auto_updates]
      #return if $0.include? "bin/gantree"
      latest_version = `gem search gantree | grep gantree | awk '{ print $2 }' | tr -d '()'`.strip
        Severity: Minor
        Found in lib/gantree/base.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def initialize params
    @stack_name = params[:stack_name]
    @rds = params[:rds]
    @rds_enabled = params[:rds?]
    @env = params[:env]
        Severity: Minor
        Found in lib/gantree/cfn/master.rb and 1 other location - About 15 mins to fix
        lib/gantree/cfn/resources.rb on lines 3..9

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def initialize params
    @stack_name = params[:stack_name]
    @rds = params[:rds]
    @env = params[:env]
    @rds_enabled = params[:rds?]
        Severity: Minor
        Found in lib/gantree/cfn/resources.rb and 1 other location - About 15 mins to fix
        lib/gantree/cfn/master.rb on lines 3..9

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language