felipero/couchrails

View on GitHub

Showing 206 of 206 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if(Element.getStyle(this.update, 'display')=='none') this.options.onShow(this.element, this.update);
Severity: Minor
Found in examples/helloworld/public/javascripts/controls.js and 1 other location - About 30 mins to fix
examples/helloworld/public/javascripts/controls.js on lines 117..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if(Element.getStyle(this.update, 'display')!='none') this.options.onHide(this.element, this.update);
Severity: Minor
Found in examples/helloworld/public/javascripts/controls.js and 1 other location - About 30 mins to fix
examples/helloworld/public/javascripts/controls.js on lines 95..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

              if (Element.descendantOf(targetNode, node)) return [targetNode];
Severity: Major
Found in examples/helloworld/public/javascripts/prototype.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return value;
    Severity: Major
    Found in examples/helloworld/public/javascripts/prototype.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return [];
      Severity: Major
      Found in examples/helloworld/public/javascripts/prototype.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return element;
        Severity: Major
        Found in examples/helloworld/public/javascripts/prototype.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return (targetNode && Element.descendantOf(targetNode, root)) ? [targetNode] : [];
          Severity: Major
          Found in examples/helloworld/public/javascripts/prototype.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                if (!responders) return;
            Severity: Major
            Found in examples/helloworld/public/javascripts/prototype.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return true;
              Severity: Major
              Found in examples/helloworld/public/javascripts/prototype.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return [targetNode];
                Severity: Major
                Found in examples/helloworld/public/javascripts/prototype.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                            if (node == targetNode) return [targetNode];
                  Severity: Major
                  Found in examples/helloworld/public/javascripts/prototype.js - About 30 mins to fix

                    Function initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      initialize: function(request){
                        this.request = request;
                        var transport  = this.transport  = request.transport,
                            readyState = this.readyState = transport.readyState;
                    
                    
                    Severity: Minor
                    Found in examples/helloworld/public/javascripts/prototype.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function initDrag has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      initDrag: function(event) {
                        if(!Object.isUndefined(Draggable._dragging[this.element]) &&
                          Draggable._dragging[this.element]) return;
                        if(Event.isLeftClick(event)) {
                          // abort on form elements, fixes a Firefox issue
                    Severity: Minor
                    Found in examples/helloworld/public/javascripts/dragdrop.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function _getWindowScroll has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      _getWindowScroll: function(w) {
                        var T, L, W, H;
                        with (w.document) {
                          if (w.document.documentElement && documentElement.scrollTop) {
                            T = documentElement.scrollTop;
                    Severity: Minor
                    Found in examples/helloworld/public/javascripts/dragdrop.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function ObjectRange has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    var ObjectRange = Class.create(Enumerable, (function() {
                      function initialize(start, end, exclusive) {
                        this.start = start;
                        this.end = end;
                        this.exclusive = exclusive;
                    Severity: Minor
                    Found in examples/helloworld/public/javascripts/prototype.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getOffsetParent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      getOffsetParent: function(element) {
                        if (element.offsetParent) return $(element.offsetParent);
                        if (element == document.body) return $(element);
                    
                        while ((element = element.parentNode) && element != document.body)
                    Severity: Minor
                    Found in examples/helloworld/public/javascripts/prototype.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function createForm has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      createForm: function() {
                        var ipe = this;
                        function addText(mode, condition) {
                          var text = ipe.options['text' + mode + 'Controls'];
                          if (!text || condition === false) return;
                    Severity: Minor
                    Found in examples/helloworld/public/javascripts/controls.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function add has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      add: function(element) {
                        element = $(element);
                        var options = Object.extend({
                          greedy:     true,
                          hoverclass: null,
                    Severity: Minor
                    Found in examples/helloworld/public/javascripts/dragdrop.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getInputs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      getInputs: function(form, typeName, name) {
                        form = $(form);
                        var inputs = form.getElementsByTagName('input');
                    
                        if (!typeName && !name) return $A(inputs).map(Element.extend);
                    Severity: Minor
                    Found in examples/helloworld/public/javascripts/prototype.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function clonePosition has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      clonePosition: function(element, source) {
                        var options = Object.extend({
                          setLeft:    true,
                          setTop:     true,
                          setWidth:   true,
                    Severity: Minor
                    Found in examples/helloworld/public/javascripts/prototype.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language