src/AbstractConfig.php
Function get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
public function get(string ...$path)
{
if (count($path) === 1) {
if (!$this->offsetExists($path[0])) {
throw ConfigKeyNotFoundException::fromPath($path);- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid using FelixArntz\Config\count() function in while loops. Open
Open
while (count($keys) > 0) {
$key = array_pop($keys);
if (!isset($arr[$key])) {
throw ConfigKeyNotFoundException::fromPath($path);
}- Read upRead up
- Exclude checks
CountInLoopExpression
Since: 2.7.0
Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.
Example
class Foo {
public function bar()
{
$array = array();
for ($i = 0; count($array); $i++) {
// ...
}
}
}