felixarntz/global-admin

View on GitHub

Showing 251 of 251 total issues

Function _ga_create_global_admin_menu has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

function _ga_create_global_admin_menu() {
    global $menu, $submenu, $_wp_real_parent_file, $pagenow;

    if ( ! is_global_admin() ) {
        return;
Severity: Minor
Found in wp-global-admin/wp-admin/includes/hacks.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ga_init has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

function ga_init() {
    if ( function_exists( 'go_init' ) ) {
        require_once GA_PATH . 'wp-global-admin/wp-includes/load.php';
        require_once GA_PATH . 'wp-global-admin/wp-includes/capabilities.php';
        require_once GA_PATH . 'wp-global-admin/wp-includes/link-template.php';
Severity: Minor
Found in wp-global-admin.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function is_global_administrator has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    function is_global_administrator( $user_id = false ) {
        $user_id = (int) $user_id;

        if ( ! is_multinetwork() ) {
            return is_super_admin( $user_id );
Severity: Minor
Found in wp-global-admin/wp-includes/capabilities.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _ga_create_global_admin_menu has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function _ga_create_global_admin_menu() {
    global $menu, $submenu, $_wp_real_parent_file, $pagenow;

    if ( ! is_global_admin() ) {
        return;
Severity: Minor
Found in wp-global-admin/wp-admin/includes/hacks.php - About 1 hr to fix

    Method ga_requirements_notice has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function ga_requirements_notice() {
        $plugin_file = plugin_basename( __FILE__ );
    
        if ( ! current_user_can( 'deactivate_plugin', $plugin_file ) ) {
            return;
    Severity: Minor
    Found in wp-global-admin.php - About 1 hr to fix

      Function _ga_user_has_networks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      function _ga_user_has_networks( $networks, $user_id ) {
          if ( ! is_multinetwork() ) {
              return $networks;
          }
      
      
      Severity: Minor
      Found in wp-global-admin/multi-network-compat.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid variables with short names like $i. Configured minimum length is 3.
      Open

                  $i            = 0;

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid deeply nested control flow statements.
      Open

                                          if ( $details->userblog_id != get_network()->site_id ) { // main blog not a spam !
                                              update_blog_status( $details->userblog_id, 'spam', '1' );
                                          }
      Severity: Major
      Found in wp-global-admin/wp-admin/global/users.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                        if ( is_global_administrator( $user->ID ) || is_super_admin( $user->ID ) ) {
                                            wp_die( sprintf( __( 'Warning! User cannot be modified. The user %s is a network administrator.' ), esc_html( $user->user_login ) ) );
                                        }
        Severity: Major
        Found in wp-global-admin/wp-admin/global/users.php - About 45 mins to fix

          Function global_site_url has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              function global_site_url( $path = '', $scheme = null ) {
                  if ( ! is_multinetwork() ) {
                      return network_site_url( $path, $scheme );
                  }
          
          
          Severity: Minor
          Found in wp-global-admin/wp-includes/link-template.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                                          if ( ! current_user_can( 'delete_users' ) ) {
                                              wp_die( __( 'Sorry, you are not allowed to access this page.' ), 403 );
                                          }
          Severity: Major
          Found in wp-global-admin/wp-admin/global/users.php - About 45 mins to fix

            Overriding WordPress globals is prohibited. Found assignment to $menu
            Open

                    $menu[5] = $networks_menu;

            All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.
            Open

                wp_die( __( 'You do not have permission to access this page.' ), 403 );

            Opening PHP tag must be on a line by itself
            Open

                ?><div id="message" class="updated notice is-dismissible"><p><?php _e( 'Settings saved.' ) ?></p></div><?php

            Inline PHP statement must end with a semicolon
            Open

                                <input name="global_name" type="text" id="global_name" class="regular-text" value="<?php echo esc_attr( get_global_option( 'global_name', '' ) ) ?>" />

            All output should be run through an escaping function (like esc_html_e() or esc_attr_e()), found '_e'.
            Open

                            <th scope="row"><label for="admin_email"><?php _e( 'Global Admin Email', 'wp-global-admin' ) ?></label></th>

            All output should be run through an escaping function (like esc_html_e() or esc_attr_e()), found '_e'.
            Open

                                        <?php _e( 'Allow network administrators to edit users', 'wp-global-admin' ); ?>

            All output should be run through an escaping function (like esc_html_e() or esc_attr_e()), found '_e'.
            Open

                                    <p><?php _e( 'Global administrator privileges cannot be removed because this user has the global admin email.', 'wp-global-admin' ); ?></p>

            Detected usage of a non-validated input variable: $_POST
            Open

                        if ( is_array( $_POST['user'] ) && ! empty( $_POST['user'] ) ) {

            All output should be run through an escaping function (like esc_html_e() or esc_attr_e()), found '_e'.
            Open

                            _e( 'Users marked as spam.' );
            Severity
            Category
            Status
            Source
            Language