Sign upLogin

felixarntz/global-admin

View on GitHub
Star
wp-global-admin/multi-network-compat.php

Summary

Maintainability
A
55 mins
Test Coverage

Function _ga_user_has_networks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

function _ga_user_has_networks( $networks, $user_id ) {
    if ( ! is_multinetwork() ) {
        return $networks;
    }
Severity: Minor
Found in wp-global-admin/multi-network-compat.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid unused parameters such as '$list_url'.
Open

function _ga_adjust_multinetwork_list_url( $list_url ) {
Severity: Minor
Found in wp-global-admin/multi-network-compat.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$add_url'.
Open

function _ga_adjust_multinetwork_add_url( $add_url ) {
Severity: Minor
Found in wp-global-admin/multi-network-compat.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$edit_url'.
Open

function _ga_adjust_multinetwork_edit_url( $edit_url, $network_id ) {
Severity: Minor
Found in wp-global-admin/multi-network-compat.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Overriding WordPress globals is prohibited. Found assignment to $menu
Open

        $menu[5] = $networks_menu;
Severity: Minor
Found in wp-global-admin/multi-network-compat.php by phpcodesniffer

Space found before comma in function call
Open

        $position = 5 + substr( base_convert( md5( $networks_menu[2] . $networks_menu[0] ), 16, 10 ) , -5 ) * 0.00001;
Severity: Minor
Found in wp-global-admin/multi-network-compat.php by phpcodesniffer

Overriding WordPress globals is prohibited. Found assignment to $menu
Open

        $menu[ "$position" ] = $networks_menu;
Severity: Minor
Found in wp-global-admin/multi-network-compat.php by phpcodesniffer

There are no issues that match your filters.

Category
Status