felixarntz/global-admin

View on GitHub
wp-global-admin/wp-includes/link-template.php

Summary

Maintainability
A
1 hr
Test Coverage

Function global_home_url has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    function global_home_url( $path = '', $scheme = null ) {
        if ( ! is_multinetwork() ) {
            return network_home_url( $path, $scheme );
        }

Severity: Minor
Found in wp-global-admin/wp-includes/link-template.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function global_site_url has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    function global_site_url( $path = '', $scheme = null ) {
        if ( ! is_multinetwork() ) {
            return network_site_url( $path, $scheme );
        }

Severity: Minor
Found in wp-global-admin/wp-includes/link-template.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid unused parameters such as '$user_id'.
Open

function _ga_adjust_edit_profile_url( $url, $user_id, $scheme ) {

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Expected 1 spaces before closing bracket; 0 found
Open

        return apply_filters( 'global_home_url', $url, $path, $orig_scheme);

There are no issues that match your filters.

Category
Status