felixarntz/plugin-lib

View on GitHub
src/components/admin-page.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function __get has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        public function __get( $property ) {
            if ( ! in_array( $property, $this->get_read_properties(), true ) ) {
                return null;
            }

Severity: Minor
Found in src/components/admin-page.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function current_user_can has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

        protected function current_user_can() {
            if ( is_array( $this->capability ) ) {
                $has_cap = false;
                foreach ( $this->capability as $capability ) {
                    if ( current_user_can( $capability ) ) {
Severity: Minor
Found in src/components/admin-page.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update_url has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

        protected function update_url() {
            $parent_file = 'admin.php';

            if ( $this->parent_slug ) {
                if ( false !== strpos( $this->parent_slug, '?' ) ) {
Severity: Minor
Found in src/components/admin-page.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid unused local variables such as '$query'.
Open

                    list( $base_slug, $query ) = explode( '?', $this->parent_slug, 2 );
Severity: Minor
Found in src/components/admin-page.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

There are no issues that match your filters.

Category
Status