felixarntz/plugin-lib

View on GitHub
src/components/admin-pages.php

Summary

Maintainability
C
1 day
Test Coverage

Function add has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

        public function add( $slug, $class_name, $parent_slug = null, $position = null, $administration_panel = 'site', $skip_menu = false ) {
            if ( ! is_subclass_of( $class_name, 'Leaves_And_Love\Plugin_Lib\Components\Admin_Page' ) ) {
                return false;
            }

Severity: Minor
Found in src/components/admin-pages.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function add_pages has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

        protected function add_pages() {
            $administration_panel = 'site';
            if ( is_network_admin() ) {
                $administration_panel = 'network';
            } elseif ( is_user_admin() ) {
Severity: Minor
Found in src/components/admin-pages.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method add has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function add( $slug, $class_name, $parent_slug = null, $position = null, $administration_panel = 'site', $skip_menu = false ) {
            if ( ! is_subclass_of( $class_name, 'Leaves_And_Love\Plugin_Lib\Components\Admin_Page' ) ) {
                return false;
            }

Severity: Minor
Found in src/components/admin-pages.php - About 1 hr to fix

    Method add_pages has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            protected function add_pages() {
                $administration_panel = 'site';
                if ( is_network_admin() ) {
                    $administration_panel = 'network';
                } elseif ( is_user_admin() ) {
    Severity: Minor
    Found in src/components/admin-pages.php - About 1 hr to fix

      Method setup_hooks has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              protected function setup_hooks() {
                  $this->actions = array(
                      array(
                          'name'     => 'admin_menu',
                          'callback' => array( $this, 'add_pages' ),
      Severity: Minor
      Found in src/components/admin-pages.php - About 1 hr to fix

        Function register_settings has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

                protected function register_settings() {
                    $administration_panel = 'site';
                    if ( is_network_admin() ) {
                        $administration_panel = 'network';
                    } elseif ( is_user_admin() ) {
        Severity: Minor
        Found in src/components/admin-pages.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method add has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                public function add( $slug, $class_name, $parent_slug = null, $position = null, $administration_panel = 'site', $skip_menu = false ) {
        Severity: Minor
        Found in src/components/admin-pages.php - About 45 mins to fix

          Avoid too many return statements within this method.
          Open

                      return true;
          Severity: Major
          Found in src/components/admin-pages.php - About 30 mins to fix

            The method add() has an NPath complexity of 288. The configured NPath complexity threshold is 200.
            Open

                    public function add( $slug, $class_name, $parent_slug = null, $position = null, $administration_panel = 'site', $skip_menu = false ) {
                        if ( ! is_subclass_of( $class_name, 'Leaves_And_Love\Plugin_Lib\Components\Admin_Page' ) ) {
                            return false;
                        }
            
            
            Severity: Minor
            Found in src/components/admin-pages.php by phpmd

            NPathComplexity

            Since: 0.1

            The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

            Example

            class Foo {
                function bar() {
                    // lots of complicated code
                }
            }

            Source https://phpmd.org/rules/codesize.html#npathcomplexity

            The method add() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
            Open

                    public function add( $slug, $class_name, $parent_slug = null, $position = null, $administration_panel = 'site', $skip_menu = false ) {
                        if ( ! is_subclass_of( $class_name, 'Leaves_And_Love\Plugin_Lib\Components\Admin_Page' ) ) {
                            return false;
                        }
            
            
            Severity: Minor
            Found in src/components/admin-pages.php by phpmd

            CyclomaticComplexity

            Since: 0.1

            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

            Example

            // Cyclomatic Complexity = 11
            class Foo {
            1   public function example() {
            2       if ($a == $b) {
            3           if ($a1 == $b1) {
                            fiddle();
            4           } elseif ($a2 == $b2) {
                            fiddle();
                        } else {
                            fiddle();
                        }
            5       } elseif ($c == $d) {
            6           while ($c == $d) {
                            fiddle();
                        }
            7        } elseif ($e == $f) {
            8           for ($n = 0; $n < $h; $n++) {
                            fiddle();
                        }
                    } else {
                        switch ($z) {
            9               case 1:
                                fiddle();
                                break;
            10              case 2:
                                fiddle();
                                break;
            11              case 3:
                                fiddle();
                                break;
                            default:
                                fiddle();
                                break;
                        }
                    }
                }
            }

            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

            Avoid unused local variables such as '$slug'.
            Open

                        foreach ( $this->pages[ $administration_panel ] as $slug => $page ) {
            Severity: Minor
            Found in src/components/admin-pages.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            There are no issues that match your filters.

            Category
            Status