felixarntz/plugin-lib

View on GitHub
src/db-objects/capabilities.php

Summary

Maintainability
D
1 day
Test Coverage

Function map_capabilities has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

        public function map_capabilities( $mode ) {
            $this->capability_mappings = array();

            if ( $mode ) {
                $this->capability_mappings[ $this->meta_capabilities['read_item'] ]   = array( $this, 'map_read_item' );
Severity: Minor
Found in src/db-objects/capabilities.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class Capabilities has an overall complexity of 60 which is very high. The configured complexity threshold is 50.
Open

    abstract class Capabilities extends Service {
        use Hook_Service_Trait;

        /**
         * Base capabilities.
Severity: Minor
Found in src/db-objects/capabilities.php by phpmd

Function grant_capabilities has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

        public function grant_capabilities( $required_cap ) {
            $this->grant_capabilities = array();

            if ( is_array( $required_cap ) ) {
                foreach ( $required_cap as $base_cap => $required ) {
Severity: Minor
Found in src/db-objects/capabilities.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Capabilities has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

    abstract class Capabilities extends Service {
        use Hook_Service_Trait;

        /**
         * Base capabilities.
Severity: Minor
Found in src/db-objects/capabilities.php - About 2 hrs to fix

    Method map_capabilities has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public function map_capabilities( $mode ) {
                $this->capability_mappings = array();
    
                if ( $mode ) {
                    $this->capability_mappings[ $this->meta_capabilities['read_item'] ]   = array( $this, 'map_read_item' );
    Severity: Minor
    Found in src/db-objects/capabilities.php - About 1 hr to fix

      Function map_item_action has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

              protected function map_item_action( $action, $user_id, $args ) {
                  /* Require an ID to be passed to this capability check. */
                  if ( ! isset( $args[0] ) || ! is_numeric( $args[0] ) ) {
                      return 'do_not_allow';
                  }
      Severity: Minor
      Found in src/db-objects/capabilities.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                                  if ( 'create_items' === $name ) {
                                      $this->capability_mappings[ $real_name ] = sprintf( 'edit_%s', $mode );
                                      continue;
                                  }
      Severity: Major
      Found in src/db-objects/capabilities.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                    if ( 'read_items' === $name || 'read_others_items' === $name ) {
                                        $this->capability_mappings[ $real_name ] = 'read';
                                        continue;
                                    }
        Severity: Major
        Found in src/db-objects/capabilities.php - About 45 mins to fix

          Function map_meta_cap has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                  protected function map_meta_cap( $caps, $cap, $user_id, $args ) {
                      if ( empty( $this->capability_mappings ) ) {
                          return $caps;
                      }
          
          
          Severity: Minor
          Found in src/db-objects/capabilities.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method map_capabilities() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
          Open

                  public function map_capabilities( $mode ) {
                      $this->capability_mappings = array();
          
                      if ( $mode ) {
                          $this->capability_mappings[ $this->meta_capabilities['read_item'] ]   = array( $this, 'map_read_item' );
          Severity: Minor
          Found in src/db-objects/capabilities.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          There are no issues that match your filters.

          Category
          Status