src/db-objects/manager-page.php
The method clean_referer() contains an exit expression. Open
Open
exit;- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}Source https://phpmd.org/rules/design.html#exitexpression
Avoid using static access to class '\Leaves_And_Love\Plugin_Lib\Fixes' in method 'clean_referer'. Open
Open
wp_safe_redirect( remove_query_arg( array( '_wp_http_referer', '_wpnonce' ), Fixes::php_filter_input( INPUT_SERVER, 'REQUEST_URI' ) ) );- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}