Sign upLogin

felixarntz/plugin-lib

View on GitHub
Star
src/db-objects/model.php

Summary

Maintainability
F
3 days
Test Coverage

Function sync_upstream has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

        public function sync_upstream() {
            $add = $this->primary_property_value() ? false : true;

            $pre = $this->pre_sync_upstream( null, $add );
            if ( null !== $pre ) {
Severity: Minor
Found in src/db-objects/model.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __set has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

        public function __set( $property, $value ) {
            if ( $property === $this->manager->get_primary_property() ) {
                return;
            }
Severity: Minor
Found in src/db-objects/model.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class Model has an overall complexity of 91 which is very high. The configured complexity threshold is 50.
Open

    abstract class Model {
        /**
         * Properties pending upstream synchronization.
         *
         * @since 1.0.0
Severity: Minor
Found in src/db-objects/model.php by phpmd

Function to_json has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

        public function to_json( $include_meta = true ) {
            $data = $this->get_property_values();

            if ( $include_meta && method_exists( $this->manager, 'get_meta' ) ) {
                $meta = $this->pending_meta;
Severity: Minor
Found in src/db-objects/model.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File model.php has 286 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Model class
 *
 * @package Leaves_And_Love\Plugin_Lib
Severity: Minor
Found in src/db-objects/model.php - About 2 hrs to fix

    Function __isset has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

            public function __isset( $property ) {
            $blacklist = $this->get_blacklist();
            if ( in_array( $property, $blacklist, true ) ) {
                return false;
            }
    Severity: Minor
    Found in src/db-objects/model.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __get has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

            public function __get( $property ) {
            $blacklist = $this->get_blacklist();
            if ( in_array( $property, $blacklist, true ) ) {
                return null;
            }
    Severity: Minor
    Found in src/db-objects/model.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method sync_upstream has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public function sync_upstream() {
            $add = $this->primary_property_value() ? false : true;

            $pre = $this->pre_sync_upstream( null, $add );
            if ( null !== $pre ) {
    Severity: Minor
    Found in src/db-objects/model.php - About 1 hr to fix

      Method __set has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public function __set( $property, $value ) {
            if ( $property === $this->manager->get_primary_property() ) {
                return;
            }
      Severity: Minor
      Found in src/db-objects/model.php - About 1 hr to fix

        Function set has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

                protected function set( $db_obj ) {
            $blacklist = $this->get_blacklist();

            $args = get_object_vars( $db_obj );
            foreach ( $args as $property => $value ) {
        Severity: Minor
        Found in src/db-objects/model.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function delete has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

                public function delete() {
            if ( ! $this->primary_property_value() ) {
                return new WP_Error( 'db_delete_error_missing_id', $this->manager->get_message( 'db_delete_error_missing_id' ) );
            }
        Severity: Minor
        Found in src/db-objects/model.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                                    if ( null === $meta[ $key ] ) {
                                unset( $meta[ $key ] );
                            }
        Severity: Major
        Found in src/db-objects/model.php - About 45 mins to fix

          Avoid too many return statements within this method.
          Open

                                      return $this->post_sync_upstream( new WP_Error( 'meta_update_error', sprintf( $this->manager->get_message( 'meta_update_error' ), $meta_key ) ), $add );
          Severity: Major
          Found in src/db-objects/model.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return $meta;
            Severity: Major
            Found in src/db-objects/model.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $this->post_sync_upstream( true, $add );
              Severity: Major
              Found in src/db-objects/model.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return false;
                Severity: Major
                Found in src/db-objects/model.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                      return $result;
                  Severity: Major
                  Found in src/db-objects/model.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return null;
                    Severity: Major
                    Found in src/db-objects/model.php - About 30 mins to fix

                      Function sync_downstream has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                              public function sync_downstream() {
            if ( ! $this->primary_property_value() ) {
                return new WP_Error( 'db_fetch_error_missing_id', $this->manager->get_message( 'db_fetch_error_missing_id' ) );
            }
                      Severity: Minor
                      Found in src/db-objects/model.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function set_value_type_safe has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                              protected function set_value_type_safe( $property, $value ) {
            if ( is_int( $this->$property ) ) {
                $this->$property = intval( $value );
            } elseif ( is_float( $this->$property ) ) {
                $this->$property = floatval( $value );
                      Severity: Minor
                      Found in src/db-objects/model.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      The method __set() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
                      Open

                              public function __set( $property, $value ) {
            if ( $property === $this->manager->get_primary_property() ) {
                return;
            }
                      Severity: Minor
                      Found in src/db-objects/model.php by phpmd

                      CyclomaticComplexity

                      Since: 0.1

                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                      Example

                      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                      The method sync_upstream() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
                      Open

                              public function sync_upstream() {
            $add = $this->primary_property_value() ? false : true;

            $pre = $this->pre_sync_upstream( null, $add );
            if ( null !== $pre ) {
                      Severity: Minor
                      Found in src/db-objects/model.php by phpmd

                      CyclomaticComplexity

                      Since: 0.1

                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                      Example

                      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              protected function pre_sync_upstream( $pre, $add = false ) {
            $prefix        = $this->manager->get_prefix();
            $singular_slug = $this->manager->get_singular_slug();

            if ( $add ) {
                      Severity: Minor
                      Found in src/db-objects/model.php and 1 other location - About 45 mins to fix
                      src/db-objects/model.php on lines 473..506

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 96.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              protected function post_sync_upstream( $result, $add = false ) {
            $prefix        = $this->manager->get_prefix();
            $singular_slug = $this->manager->get_singular_slug();

            if ( $add ) {
                      Severity: Minor
                      Found in src/db-objects/model.php and 1 other location - About 45 mins to fix
                      src/db-objects/model.php on lines 423..462

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 96.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status