Sign upLogin

felixarntz/plugin-lib

View on GitHub
Star
src/db-objects/models/core-model.php

Summary

Maintainability
C
1 day
Test Coverage

Function __set has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        public function __set( $property, $value ) {
            if ( $property === $this->manager->get_primary_property() ) {
                return;
            }
Severity: Minor
Found in src/db-objects/models/core-model.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __set has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function __set( $property, $value ) {
            if ( $property === $this->manager->get_primary_property() ) {
                return;
            }
Severity: Minor
Found in src/db-objects/models/core-model.php - About 1 hr to fix

    Function __isset has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

            public function __isset( $property ) {
            $db_fields = $this->get_db_fields();

            if ( in_array( $property, $db_fields, true ) && isset( $this->original->$property ) ) {
                return true;
    Severity: Minor
    Found in src/db-objects/models/core-model.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __get has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            public function __get( $property ) {
            $db_fields = $this->get_db_fields();

            if ( in_array( $property, $db_fields, true ) && isset( $this->original->$property ) ) {
                return $this->original->$property;
    Severity: Minor
    Found in src/db-objects/models/core-model.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function set_value_type_safe has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            protected function set_value_type_safe( $property, $value ) {
            if ( $property === $this->manager->get_primary_property() ) {
                $this->original->{$property} = intval( $value );
            } elseif ( is_int( $this->original->$property ) ) {
                $this->original->{$property} = intval( $value );
    Severity: Minor
    Found in src/db-objects/models/core-model.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method __set() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
    Open

            public function __set( $property, $value ) {
            if ( $property === $this->manager->get_primary_property() ) {
                return;
            }
    Severity: Minor
    Found in src/db-objects/models/core-model.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if ( in_array( $property, $db_fields, true ) && isset( $this->original->$property ) ) {
                $old = $this->original->$property;

                $this->set_value_type_safe( $property, $value );
    Severity: Major
    Found in src/db-objects/models/core-model.php and 1 other location - About 1 hr to fix
    src/db-objects/models/core-model.php on lines 147..156

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if ( in_array( $prefixed_property, $db_fields, true ) && isset( $this->original->$prefixed_property ) ) {
                    $old = $this->original->$prefixed_property;

                    $this->set_value_type_safe( $prefixed_property, $value );
    Severity: Major
    Found in src/db-objects/models/core-model.php and 1 other location - About 1 hr to fix
    src/db-objects/models/core-model.php on lines 130..139

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status