Sign upLogin

felixarntz/plugin-lib

View on GitHub
Star
src/fields/datetime.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function validate_single has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

        protected function validate_single( $value = null ) {
            if ( in_array( $value, $this->get_emptyish_values(), true ) ) {
                $value = '';
            }
Severity: Minor
Found in src/fields/datetime.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __construct has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        public function __construct( $manager, $id, $args = array() ) {
            if ( isset( $args['data-store'] ) ) {
                if ( ! isset( $args['store'] ) ) {
                    $args['store'] = $args['data-store'];
                } else {
Severity: Minor
Found in src/fields/datetime.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method enqueue has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function enqueue() {
            $ret = parent::enqueue();

            $assets = $this->manager->library_assets();
Severity: Minor
Found in src/fields/datetime.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                return $value;
    Severity: Major
    Found in src/fields/datetime.php - About 30 mins to fix

      Avoid excessively long variable names like $datetimepicker_version. Keep variable name length under 20.
      Open

                  $datetimepicker_version = '2.5.20';
      Severity: Minor
      Found in src/fields/datetime.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      There are no issues that match your filters.

      Category
      Status