Sign upLogin

felixarntz/plugin-lib

View on GitHub
Star
src/fields/field.php

Summary

Maintainability
F
1 wk
Test Coverage

File field.php has 613 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Field base class
 *
 * @package Leaves_And_Love\Plugin_Lib
Severity: Major
Found in src/fields/field.php - About 1 day to fix

    Function validate has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
    Open

            public function validate( $value = null ) {
            $this->maybe_resolve_dependencies();

            if ( false === $this->display ) {
                return $value;
    Severity: Minor
    Found in src/fields/field.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Field has 45 functions (exceeds 20 allowed). Consider refactoring.
    Open

        abstract class Field {
        /**
         * Field manager instance.
         *
         * @since 1.0.0
    Severity: Minor
    Found in src/fields/field.php - About 6 hrs to fix

      Function to_json has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

              public function to_json( $current_value ) {
            $this->maybe_resolve_dependencies();

            if ( $this->is_repeatable() ) {
                $current_value = (array) $current_value;
      Severity: Minor
      Found in src/fields/field.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The class Field has an overall complexity of 148 which is very high. The configured complexity threshold is 50.
      Open

          abstract class Field {
        /**
         * Field manager instance.
         *
         * @since 1.0.0
      Severity: Minor
      Found in src/fields/field.php by phpmd

      The class Field has 12 public methods. Consider refactoring Field to keep number of public methods under 10.
      Open

          abstract class Field {
        /**
         * Field manager instance.
         *
         * @since 1.0.0
      Severity: Minor
      Found in src/fields/field.php by phpmd

      TooManyPublicMethods

      Since: 0.1

      A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

      The class Field has 36 non-getter- and setter-methods. Consider refactoring Field to keep number of methods under 25.
      Open

          abstract class Field {
        /**
         * Field manager instance.
         *
         * @since 1.0.0
      Severity: Minor
      Found in src/fields/field.php by phpmd

      TooManyMethods

      Since: 0.1

      A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      The default was changed from 10 to 25 in PHPMD 2.3.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanymethods

      Function attrs has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

              protected function attrs( $attrs ) {
            $output = '';

            foreach ( $attrs as $attr => $value ) {
                if ( is_bool( $value ) ) {
      Severity: Minor
      Found in src/fields/field.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __construct has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

              public function __construct( $manager, $id, $args = array() ) {
            $this->manager = $manager;
            $this->id      = $id;

            $forbidden_keys = $this->get_forbidden_keys();
      Severity: Minor
      Found in src/fields/field.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validate has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public function validate( $value = null ) {
            $this->maybe_resolve_dependencies();

            if ( false === $this->display ) {
                return $value;
      Severity: Major
      Found in src/fields/field.php - About 2 hrs to fix

        Method to_json has 63 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public function to_json( $current_value ) {
            $this->maybe_resolve_dependencies();

            if ( $this->is_repeatable() ) {
                $current_value = (array) $current_value;
        Severity: Major
        Found in src/fields/field.php - About 2 hrs to fix

          Function render_label has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

                  public function render_label() {
            $this->maybe_resolve_dependencies();

            echo '<div id="' . esc_attr( $this->get_id_attribute() . '-label-wrap' ) . '" class="label-wrap">';
          Severity: Minor
          Found in src/fields/field.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function render_content has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

                  public function render_content( $current_value ) {
            $this->maybe_resolve_dependencies();

            echo '<div id="' . esc_attr( $this->get_id_attribute() . '-content-wrap' ) . '" class="content-wrap">';
          Severity: Minor
          Found in src/fields/field.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function render_input has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

                  public function render_input( $current_value ) {
            $this->maybe_resolve_dependencies();

            if ( $this->is_repeatable() ) {
                $current_value = (array) $current_value;
          Severity: Minor
          Found in src/fields/field.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The class Field has 20 fields. Consider redesigning Field to keep the number of fields under 15.
          Open

              abstract class Field {
        /**
         * Field manager instance.
         *
         * @since 1.0.0
          Severity: Minor
          Found in src/fields/field.php by phpmd

          TooManyFields

          Since: 0.1

          Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.

          Example

          class Person {
   protected $one;
   private $two;
   private $three;
   [... many more fields ...]
}

          Source https://phpmd.org/rules/codesize.html#toomanyfields

          Function get_input_attrs has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

                  protected function get_input_attrs( $input_attrs = array(), $as_string = true ) {
            $base_input_attrs = array(
                'id'   => $this->get_id_attribute(),
                'name' => $this->get_name_attribute(),
            );
          Severity: Minor
          Found in src/fields/field.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __construct has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  public function __construct( $manager, $id, $args = array() ) {
            $this->manager = $manager;
            $this->id      = $id;

            $forbidden_keys = $this->get_forbidden_keys();
          Severity: Minor
          Found in src/fields/field.php - About 1 hr to fix

            Method render_input has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    public function render_input( $current_value ) {
            $this->maybe_resolve_dependencies();

            if ( $this->is_repeatable() ) {
                $current_value = (array) $current_value;
            Severity: Minor
            Found in src/fields/field.php - About 1 hr to fix

              Function maybe_resolve_dependencies has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                      protected function maybe_resolve_dependencies() {
            if ( ! $this->dependency_resolver ) {
                return false;
            }
              Severity: Minor
              Found in src/fields/field.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function get_label_attrs has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                      protected function get_label_attrs( $label_attrs = array(), $as_string = true ) {
            $base_label_attrs = array(
                'id' => $this->get_id_attribute() . '-label',
            );
              Severity: Minor
              Found in src/fields/field.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function __get has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                      public function __get( $property ) {
            if ( 'manager' === $property ) {
                return null;
            }
              Severity: Minor
              Found in src/fields/field.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function render_repeatable_button has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                      protected function render_repeatable_button( $mode, $message, $hide_button = false ) {
            if ( ! $this->is_repeatable() ) {
                return;
            }
              Severity: Minor
              Found in src/fields/field.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                          return $this->post_validate_single( $value, $original );
              Severity: Major
              Found in src/fields/field.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return $validated;
                Severity: Major
                Found in src/fields/field.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return $value;
                  Severity: Major
                  Found in src/fields/field.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return $value;
                    Severity: Major
                    Found in src/fields/field.php - About 30 mins to fix

                      Function get_wrap_attrs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                              public function get_wrap_attrs( $as_string = true ) {
            $this->maybe_resolve_dependencies();

            $wrap_attrs = array(
                'id'    => $this->get_id_attribute() . '-wrap',
                      Severity: Minor
                      Found in src/fields/field.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      The method to_json() has an NPath complexity of 576. The configured NPath complexity threshold is 200.
                      Open

                              public function to_json( $current_value ) {
            $this->maybe_resolve_dependencies();

            if ( $this->is_repeatable() ) {
                $current_value = (array) $current_value;
                      Severity: Minor
                      Found in src/fields/field.php by phpmd

                      NPathComplexity

                      Since: 0.1

                      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                      Example

                      class Foo {
    function bar() {
        // lots of complicated code
    }
}

                      Source https://phpmd.org/rules/codesize.html#npathcomplexity

                      The method validate() has an NPath complexity of 2696. The configured NPath complexity threshold is 200.
                      Open

                              public function validate( $value = null ) {
            $this->maybe_resolve_dependencies();

            if ( false === $this->display ) {
                return $value;
                      Severity: Minor
                      Found in src/fields/field.php by phpmd

                      NPathComplexity

                      Since: 0.1

                      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                      Example

                      class Foo {
    function bar() {
        // lots of complicated code
    }
}

                      Source https://phpmd.org/rules/codesize.html#npathcomplexity

                      The class Field has 1263 lines of code. Current threshold is 1000. Avoid really long classes.
                      Open

                          abstract class Field {
        /**
         * Field manager instance.
         *
         * @since 1.0.0
                      Severity: Minor
                      Found in src/fields/field.php by phpmd

                      The method render_label() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                      Open

                              public function render_label() {
            $this->maybe_resolve_dependencies();

            echo '<div id="' . esc_attr( $this->get_id_attribute() . '-label-wrap' ) . '" class="label-wrap">';
                      Severity: Minor
                      Found in src/fields/field.php by phpmd

                      CyclomaticComplexity

                      Since: 0.1

                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                      Example

                      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                      The method validate() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
                      Open

                              public function validate( $value = null ) {
            $this->maybe_resolve_dependencies();

            if ( false === $this->display ) {
                return $value;
                      Severity: Minor
                      Found in src/fields/field.php by phpmd

                      CyclomaticComplexity

                      Since: 0.1

                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                      Example

                      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                      The method to_json() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
                      Open

                              public function to_json( $current_value ) {
            $this->maybe_resolve_dependencies();

            if ( $this->is_repeatable() ) {
                $current_value = (array) $current_value;
                      Severity: Minor
                      Found in src/fields/field.php by phpmd

                      CyclomaticComplexity

                      Since: 0.1

                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                      Example

                      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              protected function attrs( $attrs ) {
            $output = '';

            foreach ( $attrs as $attr => $value ) {
                if ( is_bool( $value ) ) {
                      Severity: Major
                      Found in src/fields/field.php and 1 other location - About 5 hrs to fix
                      src/template.php on lines 190..212

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 190.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status