Sign upLogin

felixarntz/plugin-lib

View on GitHub
Star
src/meta.php

Summary

Maintainability
C
1 day
Test Coverage

Function get has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        public function get( $meta_type, $object_id, $meta_key = '', $single = false ) {
            if ( is_multisite() && in_array( $meta_type, array( 'site', 'network' ), true ) ) {
                // Querying all site or network options is not possible here.
                if ( ! $meta_key ) {
                    return array();
Severity: Minor
Found in src/meta.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exists has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

        public function exists( $meta_type, $object_id, $meta_key ) {
            if ( is_multisite() ) {
                if ( 'site' === $meta_type ) {
                    if ( false === get_blog_option( $object_id, $meta_key ) ) {
                        return false;
Severity: Minor
Found in src/meta.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

        public function update( $meta_type, $object_id, $meta_key, $meta_value, $prev_value = '' ) {
            if ( is_multisite() && in_array( $meta_type, array( 'site', 'network' ), true ) ) {
                $callback = 'network' === $meta_type ? 'update_network_option' : 'update_blog_option';

                $adding = false;
Severity: Minor
Found in src/meta.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function add has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        public function add( $meta_type, $object_id, $meta_key, $meta_value, $unique = false ) {
            if ( is_multisite() && in_array( $meta_type, array( 'site', 'network' ), true ) ) {
                $callback = 'network' === $meta_type ? 'add_network_option' : 'add_blog_option';
                $result   = call_user_func( $callback, $object_id, $meta_key, $meta_value );
                if ( $result ) {
Severity: Minor
Found in src/meta.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method delete has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        public function delete( $meta_type, $object_id, $meta_key, $meta_value = '', $delete_all = false ) {
Severity: Minor
Found in src/meta.php - About 35 mins to fix

    Method update has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            public function update( $meta_type, $object_id, $meta_key, $meta_value, $prev_value = '' ) {
    Severity: Minor
    Found in src/meta.php - About 35 mins to fix

      Method add has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              public function add( $meta_type, $object_id, $meta_key, $meta_value, $unique = false ) {
      Severity: Minor
      Found in src/meta.php - About 35 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $values;
        Severity: Major
        Found in src/meta.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return false;
          Severity: Major
          Found in src/meta.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return $values[0];
            Severity: Major
            Found in src/meta.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return metadata_exists( $meta_type, $object_id, $meta_key );
              Severity: Major
              Found in src/meta.php - About 30 mins to fix

                The method get() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                Open

                        public function get( $meta_type, $object_id, $meta_key = '', $single = false ) {
            if ( is_multisite() && in_array( $meta_type, array( 'site', 'network' ), true ) ) {
                // Querying all site or network options is not possible here.
                if ( ! $meta_key ) {
                    return array();
                Severity: Minor
                Found in src/meta.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                There are no issues that match your filters.

                Category
                Status