Sign upLogin

felixarntz/post-types-definitely

View on GitHub
Star
inc/WPPTD/Components/PostType.php

Summary

Maintainability
F
5 days
Test Coverage

Function validate has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

        public function validate( $parent = null ) {
            $status = parent::validate( $parent );

            if ( $status === true ) {
Severity: Minor
Found in inc/WPPTD/Components/PostType.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File PostType.php has 388 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * WPPTD\Components\PostType class
 *
 * @package WPPTD
Severity: Minor
Found in inc/WPPTD/Components/PostType.php - About 5 hrs to fix

    Function validate_meta_values has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

            protected function validate_meta_values( $meta_values, $post_id ) {
            $meta_values_validated = array();

            $meta_values_old = array();
    Severity: Minor
    Found in inc/WPPTD/Components/PostType.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function register has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

            public function register() {
            if ( ! $this->is_already_added() ) {
                $_post_type_args = $this->args;

                unset( $_post_type_args['title'] );
    Severity: Minor
    Found in inc/WPPTD/Components/PostType.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add_to_menu has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

            public function add_to_menu( $args ) {
            if ( ! $this->show_in_menu_manually ) {
                return false;
            }
    Severity: Minor
    Found in inc/WPPTD/Components/PostType.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    PostType has 23 functions (exceeds 20 allowed). Consider refactoring.
    Open

        class PostType extends Base {

        /**
         * @since 0.5.0
         * @var WPPTD\PostTypeTableHandler Holds the list table handler instance for this post type.
    Severity: Minor
    Found in inc/WPPTD/Components/PostType.php - About 2 hrs to fix

      Function get_updated_messages has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

              public function get_updated_messages( $post, $permalink = '', $revision = false ) {
            if ( ! $this->args['messages'] ) {
                return array();
            }
      Severity: Minor
      Found in inc/WPPTD/Components/PostType.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validate has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public function validate( $parent = null ) {
            $status = parent::validate( $parent );

            if ( $status === true ) {
      Severity: Major
      Found in inc/WPPTD/Components/PostType.php - About 2 hrs to fix

        Method get_defaults has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                protected function get_defaults() {
            $defaults = array(
                'title'                => '',
                'singular_title'       => '',
                'title_gender'         => 'n',
        Severity: Minor
        Found in inc/WPPTD/Components/PostType.php - About 1 hr to fix

          Method validate_meta_values has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  protected function validate_meta_values( $meta_values, $post_id ) {
            $meta_values_validated = array();

            $meta_values_old = array();
          Severity: Minor
          Found in inc/WPPTD/Components/PostType.php - About 1 hr to fix

            Function save_meta has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                    public function save_meta( $post_id, $post, $update = false ) {
            if ( ! $this->can_save_meta( $post_id, $post ) ) {
                return;
            }
            Severity: Minor
            Found in inc/WPPTD/Components/PostType.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method register has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    public function register() {
            if ( ! $this->is_already_added() ) {
                $_post_type_args = $this->args;

                unset( $_post_type_args['title'] );
            Severity: Minor
            Found in inc/WPPTD/Components/PostType.php - About 1 hr to fix

              Method add_to_menu has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      public function add_to_menu( $args ) {
            if ( ! $this->show_in_menu_manually ) {
                return false;
            }
              Severity: Minor
              Found in inc/WPPTD/Components/PostType.php - About 1 hr to fix

                Method get_updated_messages has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        public function get_updated_messages( $post, $permalink = '', $revision = false ) {
            if ( ! $this->args['messages'] ) {
                return array();
            }
                Severity: Minor
                Found in inc/WPPTD/Components/PostType.php - About 1 hr to fix

                  Function can_save_meta has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                          protected function can_save_meta( $post_id, $post ) {
            if ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ) {
                return false;
            }
                  Severity: Minor
                  Found in inc/WPPTD/Components/PostType.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this method.
                  Open

                              return true;
                  Severity: Major
                  Found in inc/WPPTD/Components/PostType.php - About 30 mins to fix

                    Function validate_meta_value has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                            protected function validate_meta_value( $field, $meta_value, $meta_value_old ) {
            $meta_value = $field->validate_meta_value( $meta_value );
            $error = false;
            $changed = false;
                    Severity: Minor
                    Found in inc/WPPTD/Components/PostType.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                foreach ( $this->get_children( 'WPPTD\Components\Metabox' ) as $metabox ) {
                foreach ( $metabox->get_children() as $field ) {
                    $meta_value_old = wpptd_get_post_meta_value( $post_id, $field->slug );
                    if ( $meta_value_old === null ) {
                        $meta_value_old = $field->default;
                    Severity: Major
                    Found in inc/WPPTD/Components/PostType.php and 1 other location - About 5 hrs to fix
                    inc/WPPTD/Components/Taxonomy.php on lines 446..468

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 184.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            public function save_meta( $post_id, $post, $update = false ) {
            if ( ! $this->can_save_meta( $post_id, $post ) ) {
                return;
            }
                    Severity: Major
                    Found in inc/WPPTD/Components/PostType.php and 1 other location - About 2 hrs to fix
                    inc/WPPTD/Components/Taxonomy.php on lines 186..203

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 128.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            protected function add_settings_message( $errors, $post_id ) {
            if ( count( $errors ) > 0 ) {
                $error_text = __( 'Some errors occurred while trying to save the following post meta:', 'post-types-definitely' );
                foreach ( $errors as $field_slug => $error ) {
                    $error_text .= '<br/><em>' . $field_slug . '</em>: ' . $error->get_error_message();
                    Severity: Major
                    Found in inc/WPPTD/Components/PostType.php and 1 other location - About 1 hr to fix
                    inc/WPPTD/Components/Taxonomy.php on lines 534..543

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 105.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status