Sign upLogin

felixarntz/post-types-definitely

View on GitHub
Star
inc/WPPTD/Components/Taxonomy.php

Summary

Maintainability
F
3 days
Test Coverage

Function validate has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

        public function validate( $parent = null ) {
            $status = parent::validate( $parent );

            if ( $status === true ) {
Severity: Minor
Found in inc/WPPTD/Components/Taxonomy.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate_meta_values has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        protected function validate_meta_values( $meta_values, $term_id ) {
            $meta_values_validated = array();

            $meta_values_old = array();
Severity: Minor
Found in inc/WPPTD/Components/Taxonomy.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function register has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

        public function register() {
            if ( $this->registered ) {
                return;
            }
Severity: Minor
Found in inc/WPPTD/Components/Taxonomy.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Taxonomy.php has 260 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * WPPTD\Components\Taxonomy class
 *
 * @package WPPTD
Severity: Minor
Found in inc/WPPTD/Components/Taxonomy.php - About 2 hrs to fix

    Method validate has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public function validate( $parent = null ) {
            $status = parent::validate( $parent );

            if ( $status === true ) {
    Severity: Minor
    Found in inc/WPPTD/Components/Taxonomy.php - About 1 hr to fix

      Function save_meta has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

              public function save_meta( $term_id, $term, $update = false ) {
            if ( ! $this->can_save_meta( $term_id, $term ) ) {
                return;
            }
      Severity: Minor
      Found in inc/WPPTD/Components/Taxonomy.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_defaults has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              protected function get_defaults() {
            $defaults = array(
                'title'              => '',
                'singular_title'     => '',
                'title_gender'       => 'n',
      Severity: Minor
      Found in inc/WPPTD/Components/Taxonomy.php - About 1 hr to fix

        Method validate_meta_values has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                protected function validate_meta_values( $meta_values, $term_id ) {
            $meta_values_validated = array();

            $meta_values_old = array();
        Severity: Minor
        Found in inc/WPPTD/Components/Taxonomy.php - About 1 hr to fix

          Method register has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  public function register() {
            if ( $this->registered ) {
                return;
            }
          Severity: Minor
          Found in inc/WPPTD/Components/Taxonomy.php - About 1 hr to fix

            Function can_save_meta has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                    protected function can_save_meta( $term_id, $term ) {
            if ( ! wpptd_supports_termmeta() ) {
                return false;
            }
            Severity: Minor
            Found in inc/WPPTD/Components/Taxonomy.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                        return true;
            Severity: Major
            Found in inc/WPPTD/Components/Taxonomy.php - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          foreach ( $this->get_children( 'WPPTD\Components\TermMetabox' ) as $metabox ) {
                foreach ( $metabox->get_children() as $field ) {
                    $meta_value_old = wpptd_get_term_meta_value( $term_id, $field->slug );
                    if ( $meta_value_old === null ) {
                        $meta_value_old = $field->default;
              Severity: Major
              Found in inc/WPPTD/Components/Taxonomy.php and 1 other location - About 5 hrs to fix
              inc/WPPTD/Components/PostType.php on lines 617..639

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 184.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      public function save_meta( $term_id, $term, $update = false ) {
            if ( ! $this->can_save_meta( $term_id, $term ) ) {
                return;
            }
              Severity: Major
              Found in inc/WPPTD/Components/Taxonomy.php and 1 other location - About 2 hrs to fix
              inc/WPPTD/Components/PostType.php on lines 264..281

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 128.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      protected function add_settings_message( $errors, $term_id ) {
            if ( count( $errors ) > 0 ) {
                $error_text = __( 'Some errors occurred while trying to save the following term meta:', 'post-types-definitely' );
                foreach ( $errors as $field_slug => $error ) {
                    $error_text .= '<br/><em>' . $field_slug . '</em>: ' . $error->get_error_message();
              Severity: Major
              Found in inc/WPPTD/Components/Taxonomy.php and 1 other location - About 1 hr to fix
              inc/WPPTD/Components/PostType.php on lines 746..755

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 105.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status