Sign upLogin

felixarntz/post-types-definitely

View on GitHub
Star

Showing 187 of 187 total issues

Function wpptd_get_post_meta_values has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    function wpptd_get_post_meta_values( $id, $single = null, $formatted = false ) {
        $_meta_values = get_post_meta( $id );

        $meta_values = array();
Severity: Minor
Found in inc/functions.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function enqueue_assets has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

        public function enqueue_assets() {
            $screen = get_current_screen();

            if ( isset( $screen->taxonomy ) && $screen->taxonomy ) {
                $taxonomy = ComponentManager::get( '*.*.' . $screen->taxonomy, 'WPDLib\Components\Menu.WPPTD\Components\PostType.WPPTD\Components\Taxonomy', true );
Severity: Minor
Found in inc/WPPTD/Admin.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate_meta_values has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

        protected function validate_meta_values( $meta_values, $post_id ) {
            $meta_values_validated = array();

            $meta_values_old = array();
Severity: Minor
Found in inc/WPPTD/Components/PostType.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

        public function validate( $parent = null ) {
            $status = parent::validate( $parent );

            if ( $status === true ) {
Severity: Minor
Found in inc/WPPTD/Components/Taxonomy.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function render has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

        public function render( $post ) {
            $parent_post_type = $this->get_parent();

            if ( 'side' == $this->args['context'] ) {
                echo '<div class="wpdlib-narrow">';
Severity: Minor
Found in inc/WPPTD/Components/Metabox.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate_meta_values has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        protected function validate_meta_values( $meta_values, $term_id ) {
            $meta_values_validated = array();

            $meta_values_old = array();
Severity: Minor
Found in inc/WPPTD/Components/Taxonomy.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_media_view_strings has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        public function get_media_view_strings( $strings, $post ) {
            if ( $post ) {
                $post_type = ComponentManager::get( '*.' . $post->post_type, 'WPDLib\Components\Menu.WPPTD\Components\PostType', true );
                if ( $post_type ) {
                    $labels = $post_type->labels;
Severity: Minor
Found in inc/WPPTD/Admin.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function maybe_register_related_objects_field has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        public static function maybe_register_related_objects_field( $object, $args, $component, $component_parent ) {
            if ( ! isset( $args['options'] ) || ! is_array( $args['options'] ) || 1 !== count( $args['options'] ) ) {
                return;
            }
Severity: Minor
Found in inc/WPPTD/Utility.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parse_meta_value has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        public static function parse_meta_value( $meta_value, $field, $single = null, $formatted = false ) {
            $_meta_value = $meta_value;
            $meta_value = null;

            $type_hint = $field->validate_meta_value( null, true );
Severity: Minor
Found in inc/WPPTD/Utility.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function register has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        public function register() {
            if ( ! $this->is_already_added() ) {
                $_post_type_args = $this->args;

                unset( $_post_type_args['title'] );
Severity: Minor
Found in inc/WPPTD/Components/PostType.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function add_to_menu has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

        public function add_to_menu( $args ) {
            if ( ! $this->show_in_menu_manually ) {
                return false;
            }
Severity: Minor
Found in inc/WPPTD/Components/PostType.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method term_submit_metabox has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function term_submit_metabox( $term ) {
            $screen = get_current_screen();

            $tax = $screen->taxonomy;
            if ( empty( $tax ) ) {
Severity: Major
Found in inc/WPPTD/Admin.php - About 2 hrs to fix

    PostType has 23 functions (exceeds 20 allowed). Consider refactoring.
    Open

        class PostType extends Base {

        /**
         * @since 0.5.0
         * @var WPPTD\PostTypeTableHandler Holds the list table handler instance for this post type.
    Severity: Minor
    Found in inc/WPPTD/Components/PostType.php - About 2 hrs to fix

      Function handle_term_bulk_actions has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

              public function handle_term_bulk_actions() {
            global $taxnow;

            // do not run this on a term edit form
            if ( isset( $_GET['tag_ID'] ) ) {
      Severity: Minor
      Found in inc/WPPTD/Admin.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function wpptd_get_term_meta_value has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          function wpptd_get_term_meta_value( $id, $meta_key, $single = null, $formatted = false ) {
        if ( ! wpptd_supports_termmeta() ) {
            if ( $single ) {
                return null;
            }
      Severity: Minor
      Found in inc/functions.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_updated_messages has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

              public function get_updated_messages( $post, $permalink = '', $revision = false ) {
            if ( ! $this->args['messages'] ) {
                return array();
            }
      Severity: Minor
      Found in inc/WPPTD/Components/PostType.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              public function save_meta( $term_id, $term, $update = false ) {
            if ( ! $this->can_save_meta( $term_id, $term ) ) {
                return;
            }
      Severity: Major
      Found in inc/WPPTD/Components/Taxonomy.php and 1 other location - About 2 hrs to fix
      inc/WPPTD/Components/PostType.php on lines 264..281

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 128.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              public function save_meta( $post_id, $post, $update = false ) {
            if ( ! $this->can_save_meta( $post_id, $post ) ) {
                return;
            }
      Severity: Major
      Found in inc/WPPTD/Components/PostType.php and 1 other location - About 2 hrs to fix
      inc/WPPTD/Components/Taxonomy.php on lines 186..203

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 128.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      ActionHandler has 22 functions (exceeds 20 allowed). Consider refactoring.
      Open

          abstract class ActionHandler {
        /**
         * @since 0.6.1
         * @var WPDLib\Components\Base Holds the component this action handler should manage.
         */
      Severity: Minor
      Found in inc/WPPTD/ActionHandler.php - About 2 hrs to fix

        App has 22 functions (exceeds 20 allowed). Consider refactoring.
        Open

            class App extends Plugin {

        /**
         * @since 0.5.0
         * @var array Holds the plugin data.
        Severity: Minor
        Found in inc/WPPTD/App.php - About 2 hrs to fix
          Severity
          Category
          Status
          Source
          Language