Sign upLogin

felixarntz/theme-boilerplate

View on GitHub
Star

Showing 194 of 194 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if ( ! empty( $entry_terms_settings ) ) {
                $customizer->add_partial( $post_type->name . '_entry_terms', array(
                    Super_Awesome_Theme_Customize_Partial::PROP_SETTINGS            => $entry_terms_settings,
                    Super_Awesome_Theme_Customize_Partial::PROP_SELECTOR            => '.type-' . $post_type->name . ' .entry-terms',
                    Super_Awesome_Theme_Customize_Partial::PROP_RENDER_CALLBACK     => array( $this, 'partial_entry_terms' ),
Severity: Minor
Found in inc/library/content-types/class-content-types.php and 1 other location - About 55 mins to fix
inc/library/content-types/class-content-types.php on lines 461..470

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function handle_sticky_elements has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    protected function handle_sticky_elements() {

        // Skip for now since it is neither possible to set state nor animate position style based on position observer.
        if ( ! $this->is_amp() || true ) {
            return;
Severity: Minor
Found in inc/library/amp/class-amp.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function initializeHeaderSiteBranding has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    initializeHeaderSiteBranding() {
        const headerSiteBranding = document.querySelector( '.site-custom-header .site-branding' );
        const offset             = headerSiteBranding ? ( headerSiteBranding.offsetTop ? headerSiteBranding.offsetTop : ( headerSiteBranding.offsetParent ? headerSiteBranding.offsetParent.offsetTop : 0 ) ) : 0;

        if ( ! headerSiteBranding ) {
Severity: Minor
Found in assets/src/js/theme/sticky.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function __call( $method, $args ) {
        switch ( $method ) {
            case 'register_settings':
            case 'register_widget_areas':
            case 'register_customize_controls_js':
Severity: Minor
Found in inc/library/footer-widget-areas/class-footer-widget-areas.php and 1 other location - About 45 mins to fix
inc/library/sticky-elements/class-sticky-elements.php on lines 100..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function __call( $method, $args ) {
        switch ( $method ) {
            case 'register_settings':
            case 'register_customize_controls_js':
            case 'register_customize_preview_js':
Severity: Minor
Found in inc/library/sticky-elements/class-sticky-elements.php and 1 other location - About 45 mins to fix
inc/library/footer-widget-areas/class-footer-widget-areas.php on lines 145..156

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

                    for (j = baseParts.length; j > 0; j -= 1) {
                        mapValue = map[baseParts.slice(0, j).join('/')];

                        //baseName segment has  config, find if it has one for
                        //this name.
Severity: Major
Found in assets/vendor/selectWoo/dist/js/selectWoo.full.js - About 45 mins to fix

    Function register_customize_controls_js has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function register_customize_controls_js( $assets ) {
        $data = array(
            'postTypes' => array(),
        );
    Severity: Minor
    Found in inc/library/content-types/class-content-types.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __call has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __call( $method, $args ) {
        switch ( $method ) {
            case 'register_main_assets':
            case 'disable_special_page_styles':
            case 'print_detect_js_svg_support_script':
    Severity: Minor
    Found in inc/library/assets/class-assets.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add_dropdown_icon_to_menu_link has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function add_dropdown_icon_to_menu_link( $title, $item, $args ) {
        if ( in_array( $args->theme_location, array( 'primary', 'primary_df' ), true ) ) {
            foreach ( $item->classes as $value ) {
                if ( 'menu-item-has-children' === $value || 'page_item_has_children' === $value ) {
                    $title .= $this->get_dependency( 'icons' )->get_svg( 'angle-down' );
    Severity: Minor
    Found in inc/library/navbar/class-navbar.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function register_widget_areas has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function register_widget_areas( $widgets ) {
        $widgets->register_widget_area( new Super_Awesome_Theme_Widget_Area(
            'primary',
            array(
                Super_Awesome_Theme_Widget_Area::PROP_TITLE       => __( 'Primary Sidebar', 'super-awesome-theme' ),
    Severity: Minor
    Found in inc/library/sidebar/class-sidebar.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        if (i === 0 || (i === 1 && name[2] === '..') || name[i - 1] === '..') {
                        continue;
                    } else if (i > 0) {
                        name.splice(i - 1, 2);
                        i -= 2;
    Severity: Major
    Found in assets/vendor/selectWoo/dist/js/selectWoo.full.js - About 45 mins to fix

      Function get_jed_locale_data_for_domain has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function get_jed_locale_data_for_domain( $domain ) {
        $translations = get_translations_for_domain( $domain );

        $locale = array(
            '' => array(
      Severity: Minor
      Found in inc/library/assets/class-assets.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function render has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function render( array $instance ) {
        $login_url      = '';
        $login_label    = '';
        $register_url   = '';
        $register_label = '';
      Severity: Minor
      Found in inc/library/widgets/class-login-links-widget.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function super_awesome_theme_infinite_scroll_render has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function super_awesome_theme_infinite_scroll_render() {
    while ( have_posts() ) {
        the_post();
        if ( is_search() ) :
            get_template_part( 'template-parts/content', 'search' );
      Severity: Minor
      Found in inc/plugin-compat/jetpack.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

              $assets->register_asset( new Super_Awesome_Theme_Script(
            'super-awesome-theme-sidebar-customize-controls',
            get_theme_file_uri( '/assets/dist/js/sidebar.customize-controls.js' ),
            array(
                Super_Awesome_Theme_Script::PROP_DEPENDENCIES => array( 'customize-controls', 'wp-i18n' ),
      Severity: Major
      Found in inc/library/sidebar/class-sidebar.php and 4 other locations - About 40 mins to fix
      inc/library/colors/class-colors.php on lines 384..395
      inc/library/content-types/class-content-types.php on lines 521..532
      inc/library/sticky-elements/class-sticky-elements.php on lines 145..156
      inc/library/widgets/class-widgets.php on lines 437..448

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

              $assets->register_asset( new Super_Awesome_Theme_Script(
            'super-awesome-theme-sticky-elements-customize-controls',
            get_theme_file_uri( '/assets/dist/js/sticky-elements.customize-controls.js' ),
            array(
                Super_Awesome_Theme_Script::PROP_DEPENDENCIES => array( 'customize-controls', 'wp-i18n' ),
      Severity: Major
      Found in inc/library/sticky-elements/class-sticky-elements.php and 4 other locations - About 40 mins to fix
      inc/library/colors/class-colors.php on lines 384..395
      inc/library/content-types/class-content-types.php on lines 521..532
      inc/library/sidebar/class-sidebar.php on lines 317..328
      inc/library/widgets/class-widgets.php on lines 437..448

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

              $assets->register_asset( new Super_Awesome_Theme_Script(
            'super-awesome-theme-widgets-customize-controls',
            get_theme_file_uri( '/assets/dist/js/widgets.customize-controls.js' ),
            array(
                Super_Awesome_Theme_Script::PROP_DEPENDENCIES => array( 'customize-controls', 'wp-i18n' ),
      Severity: Major
      Found in inc/library/widgets/class-widgets.php and 4 other locations - About 40 mins to fix
      inc/library/colors/class-colors.php on lines 384..395
      inc/library/content-types/class-content-types.php on lines 521..532
      inc/library/sidebar/class-sidebar.php on lines 317..328
      inc/library/sticky-elements/class-sticky-elements.php on lines 145..156

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

              $assets->register_asset( new Super_Awesome_Theme_Script(
            'super-awesome-theme-content-types-customize-controls',
            get_theme_file_uri( '/assets/dist/js/content-types.customize-controls.js' ),
            array(
                Super_Awesome_Theme_Script::PROP_DEPENDENCIES => array( 'customize-controls', 'wp-i18n' ),
      Severity: Major
      Found in inc/library/content-types/class-content-types.php and 4 other locations - About 40 mins to fix
      inc/library/colors/class-colors.php on lines 384..395
      inc/library/sidebar/class-sidebar.php on lines 317..328
      inc/library/sticky-elements/class-sticky-elements.php on lines 145..156
      inc/library/widgets/class-widgets.php on lines 437..448

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

              $assets->register_asset( new Super_Awesome_Theme_Script(
            'super-awesome-theme-colors-customize-controls',
            get_theme_file_uri( '/assets/dist/js/colors.customize-controls.js' ),
            array(
                Super_Awesome_Theme_Script::PROP_DEPENDENCIES => array( 'customize-controls', 'wp-i18n' ),
      Severity: Major
      Found in inc/library/colors/class-colors.php and 4 other locations - About 40 mins to fix
      inc/library/content-types/class-content-types.php on lines 521..532
      inc/library/sidebar/class-sidebar.php on lines 317..328
      inc/library/sticky-elements/class-sticky-elements.php on lines 145..156
      inc/library/widgets/class-widgets.php on lines 437..448

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method add_size has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function add_size( $slug, $width, $height, $crop = false, $selectable = false ) {
      Severity: Minor
      Found in inc/library/image-sizes/class-image-sizes.php - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language