Showing 1 of 1 total issue
The method create_notice has a boolean flag argument $dismissible, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function create_notice( string $message, string $type = Admin_Notice_Types::ERROR, bool $dismissible = false ) : Admin_Notice {- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}