felixarntz/wp-encrypt

View on GitHub
inc/WPENC/Core/Client.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function signed_request has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

        public function signed_request( $endpoint, $data = null ) {
            $account_keypair = AccountKeyPair::get();

            $account_key_resource = $account_keypair->read_private();
            if ( is_wp_error( $account_key_resource ) ) {
Severity: Minor
Found in inc/WPENC/Core/Client.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method signed_request has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function signed_request( $endpoint, $data = null ) {
            $account_keypair = AccountKeyPair::get();

            $account_key_resource = $account_keypair->read_private();
            if ( is_wp_error( $account_key_resource ) ) {
Severity: Minor
Found in inc/WPENC/Core/Client.php - About 1 hr to fix

    Method request has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public function request( $endpoint, $method = 'GET', $data = null ) {
                if ( is_array( $data ) ) {
                    $data = json_encode( $data );
                }
    
    
    Severity: Minor
    Found in inc/WPENC/Core/Client.php - About 1 hr to fix

      Function request has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

              public function request( $endpoint, $method = 'GET', $data = null ) {
                  if ( is_array( $data ) ) {
                      $data = json_encode( $data );
                  }
      
      
      Severity: Minor
      Found in inc/WPENC/Core/Client.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return $this->request( $endpoint, 'POST', array(
                      'header'    => $header,
                      'protected'    => $protected64,
                      'payload'    => $data64,
                      'signature'    => $signature64,
      Severity: Major
      Found in inc/WPENC/Core/Client.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status