Sign upLogin

felixarntz/wp-gcs-offload

View on GitHub
Star
inc/WPGCSOffload/Admin/Settings.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function get_setting has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

        public function get_setting( $name ) {
            if ( Admin::is_network_active() && ( 'authentication_key' === $name || 'bucket_name' === $name ) ) {
                $constant_name = $this->get_setting_constant_name( $name );

                if ( defined( $constant_name ) ) {
Severity: Minor
Found in inc/WPGCSOffload/Admin/Settings.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_site_configuration_fields has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function get_site_configuration_fields() {
            return array(
                'gcs_mode'                    => array(
                    'title'                        => __( 'Plugin Mode', 'wp-gcs-offload' ),
                    'description'                => __( 'Specify whether your site should prefer local or remote attachment files.', 'wp-gcs-offload' ),
Severity: Minor
Found in inc/WPGCSOffload/Admin/Settings.php - About 1 hr to fix

    Method get_setting has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public function get_setting( $name ) {
            if ( Admin::is_network_active() && ( 'authentication_key' === $name || 'bucket_name' === $name ) ) {
                $constant_name = $this->get_setting_constant_name( $name );

                if ( defined( $constant_name ) ) {
    Severity: Minor
    Found in inc/WPGCSOffload/Admin/Settings.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                  return '';
      Severity: Major
      Found in inc/WPGCSOffload/Admin/Settings.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                                return (bool) $settings[ $name ];
        Severity: Major
        Found in inc/WPGCSOffload/Admin/Settings.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return false;
          Severity: Major
          Found in inc/WPGCSOffload/Admin/Settings.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $settings[ $name ];
            Severity: Major
            Found in inc/WPGCSOffload/Admin/Settings.php - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status