Sign upLogin

felixarntz/wp-shortcode-cache

View on GitHub
Star
wp-shortcode-cache/class-wp-shortcode-cache-tag.php

Summary

Maintainability
C
1 day
Test Coverage

Function fill_external_data has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function fill_external_data( $attr ) {
        foreach ( $this->callbacks as $identifier => $params ) {
            if ( isset( $attr[ $identifier ] ) ) {
                continue;
            }
Severity: Minor
Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fill_external_data has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function fill_external_data( $attr ) {
        foreach ( $this->callbacks as $identifier => $params ) {
            if ( isset( $attr[ $identifier ] ) ) {
                continue;
            }
Severity: Minor
Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php - About 1 hr to fix

    Function register_external_data_values has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function register_external_data_values( $external_data ) {
        $error = new WP_Error();

        foreach ( $external_data as $identifier => $params ) {
            if ( is_string( $params ) ) {
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method fill_external_data() has an NPath complexity of 225. The configured NPath complexity threshold is 200.
    Open

        public function fill_external_data( $attr ) {
        foreach ( $this->callbacks as $identifier => $params ) {
            if ( isset( $attr[ $identifier ] ) ) {
                continue;
            }
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method fill_external_data() has a Cyclomatic Complexity of 20. The configured cyclomatic complexity threshold is 10.
    Open

        public function fill_external_data( $attr ) {
        foreach ( $this->callbacks as $identifier => $params ) {
            if ( isset( $attr[ $identifier ] ) ) {
                continue;
            }
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Missing class import via use statement (line '153', column '14').
    Open

            return new WP_Error( 'invalid_external_data_value_type', sprintf( __( '%s is not a valid type for external cache data registered for shortcode %2$s.', 'wp-shortcode-cache' ), esc_attr( $type ), esc_attr( $this->tag ) ) );
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '90', column '16').
    Open

            $error = new WP_Error();
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '176', column '14').
    Open

            return new WP_Error( 'invalid_external_data_value_identifier', sprintf( __( 'No external cache data value with identifier %1$s is registered for shortcode %2$s.', 'wp-shortcode-cache' ), esc_attr( $identifier ), esc_attr( $this->tag ) ) );
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Detected usage of a non-sanitized input variable: $_REQUEST
    Open

                                $attr[ $identifier ] = $_REQUEST[ $params['name'] ];
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php by phpcodesniffer

    Multiple placeholders should be ordered. Mix of ordered and non-ordered placeholders found. Found: %s, %2$s.
    Open

            return new WP_Error( 'invalid_external_data_value_type', sprintf( __( '%s is not a valid type for external cache data registered for shortcode %2$s.', 'wp-shortcode-cache' ), esc_attr( $type ), esc_attr( $this->tag ) ) );
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php by phpcodesniffer

    Processing form data without nonce verification.
    Open

                                $attr[ $identifier ] = $_POST[ $params['name'] ];
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php by phpcodesniffer

    Processing form data without nonce verification.
    Open

                            if ( isset( $_POST[ $params['name'] ] ) ) {
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php by phpcodesniffer

    A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.
    Open

            return new WP_Error( 'invalid_external_data_value_identifier', sprintf( __( 'No external cache data value with identifier %1$s is registered for shortcode %2$s.', 'wp-shortcode-cache' ), esc_attr( $identifier ), esc_attr( $this->tag ) ) );
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php by phpcodesniffer

    Missing wp_unslash() before sanitization.
    Open

                                $attr[ $identifier ] = $_REQUEST[ $params['name'] ];
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php by phpcodesniffer

    Missing wp_unslash() before sanitization.
    Open

                                $attr[ $identifier ] = $_POST[ $params['name'] ];
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php by phpcodesniffer

    Detected usage of a non-sanitized input variable: $_GET
    Open

                                $attr[ $identifier ] = $_GET[ $params['name'] ];
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php by phpcodesniffer

    Missing wp_unslash() before sanitization.
    Open

                                $attr[ $identifier ] = $_GET[ $params['name'] ];
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php by phpcodesniffer

    Detected usage of a non-sanitized input variable: $_POST
    Open

                                $attr[ $identifier ] = $_POST[ $params['name'] ];
    Severity: Minor
    Found in wp-shortcode-cache/class-wp-shortcode-cache-tag.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status