wp-shortcode-cache/class-wp-shortcode-cache.php
Method register_external_data_value
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public function register_external_data_value( $tag, $data_identifier, $data_name, $data_type = 'global', $data_args = array() ) {
Function retrieve_cache_data
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
private function retrieve_cache_data( $tag, $attr, $matches ) {
if ( isset( $this->tags[ $tag ] ) ) {
$attr = $this->tags[ $tag ]->fill_external_data( $attr );
} else {
/* By default, always include global $post and the current user. */
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Missing class import via use statement (line '127', column '30'). Open
Open
$this->tags[ $tag ] = new WP_Shortcode_Cache_Tag( $tag );
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '59', column '30'). Open
Open
$this->tags[ $tag ] = new WP_Shortcode_Cache_Tag( $tag );
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '86', column '30'). Open
Open
$this->tags[ $tag ] = new WP_Shortcode_Cache_Tag( $tag );
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '107', column '15'). Open
Open
return new WP_Error( 'no_external_data', sprintf( __( 'No external cache data is registered for shortcode %s.', 'wp-shortcode-cache' ), esc_attr( $tag ) ) );
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid unused parameters such as '$expire'. Open
Open
public function set_cached_output( $cache_key, $value, $expire = 0 ) {
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}