Sign upLogin

felixarntz/wp-shortcode-cache

View on GitHub
Star
wp-shortcode-cache/functions.php

Summary

Maintainability
A
35 mins
Test Coverage

Method wp_shortcode_cache_register_external_data_value has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function wp_shortcode_cache_register_external_data_value( $tag, $data_identifier, $data_name, $data_type = 'global', $data_args = array() ) {
Severity: Minor
Found in wp-shortcode-cache/functions.php - About 35 mins to fix

    Avoid using static access to class 'WP_Shortcode_Cache' in method 'wp_shortcode_cache'.
    Open

        return WP_Shortcode_Cache::instance();
    Severity: Minor
    Found in wp-shortcode-cache/functions.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    There are no issues that match your filters.

    Category
    Status