Sign upLogin

fenos/Notifynder

View on GitHub
Star
src/Notifynder/Builder/Builder.php

Summary

Maintainability
A
2 hrs
Test Coverage

Builder has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class Builder implements ArrayAccess
{
    /**
     * @var Notification
     */
Severity: Minor
Found in src/Notifynder/Builder/Builder.php - About 2 hrs to fix

    The method setEntityData uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            TypeChecker::isNumeric($entity[0]);

            $type = notifynder_config()->getNotifiedModel();
            $id = $entity[0];
    Severity: Minor
    Found in src/Notifynder/Builder/Builder.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using short method names like Builder::to(). The configured minimum method name length is 3.
    Open

        public function to()
    {
        $args = func_get_args();
        $this->setEntityData($args, 'to');
    Severity: Minor
    Found in src/Notifynder/Builder/Builder.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

                $id = $entity[1];
    Severity: Minor
    Found in src/Notifynder/Builder/Builder.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status