Sign upLogin

fewieden/MMM-ping

View on GitHub
Star

Showing 3 of 4 total issues

Function checkCommands has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    checkCommands(data) {
        if (/(HELP)/g.test(data)) {
            if (/(CLOSE)/g.test(data) && !/(OPEN)/g.test(data)) {
                this.sendNotification('CLOSE_MODAL');
            } else if (/(OPEN)/g.test(data) && !/(CLOSE)/g.test(data)) {
Severity: Minor
Found in MMM-ping.js - About 1 hr to fix

    Function checkCommands has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        checkCommands(data) {
        if (/(HELP)/g.test(data)) {
            if (/(CLOSE)/g.test(data) && !/(OPEN)/g.test(data)) {
                this.sendNotification('CLOSE_MODAL');
            } else if (/(OPEN)/g.test(data) && !/(CLOSE)/g.test(data)) {
    Severity: Minor
    Found in MMM-ping.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Multiple headers with the same content
    Open

    ### Added
    Severity: Info
    Found in CHANGELOG.md by markdownlint

    MD024 - Multiple headers with the same content

    Tags: headers

    Aliases: no-duplicate-header

    Parameters: allowdifferentnesting (boolean; default false)

    This rule is triggered if there are multiple headers in the document that have the same text:

    # Some text

## Some text

    To fix this, ensure that the content of each header is different:

    # Some text

## Some more text

    Rationale: Some markdown parses generate anchors for headers based on the header name, and having headers with the same content can cause problems with this.

    If the parameter allow_different_nesting is set to true, header duplication under different nesting is allowed, like it usually happens in change logs:

    # Change log

## 2.0.0

### Bug fixes

### Features

## 1.0.0

### Bug fixes
    Severity
    Category
    Status
    Source
    Language