Sign upLogin

fewieden/MMM-voice

View on GitHub
Star

Showing 10 of 10 total issues

Function socketNotificationReceived has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    socketNotificationReceived(notification, payload) {
        if (notification === 'READY') {
            this.icon = 'fa-microphone';
            this.mode = this.translate('NO_MODE');
            this.pulsing = false;
Severity: Minor
Found in MMM-voice.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handleData has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    handleData(data) {
        if (typeof data === 'string') {
            if (this.config.debug) {
                console.log(`${this.name} has recognized: ${data}`);
                this.sendSocketNotification('DEBUG', data);
Severity: Minor
Found in node_helper.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function socketNotificationReceived has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    socketNotificationReceived(notification, payload) {
        if (notification === 'READY') {
            this.icon = 'fa-microphone';
            this.mode = this.translate('NO_MODE');
            this.pulsing = false;
Severity: Minor
Found in MMM-voice.js - About 1 hr to fix

    Function getDom has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        getDom() {
        const wrapper = document.createElement('div');
        const voice = document.createElement('div');
        voice.classList.add('small', 'align-left');
    Severity: Minor
    Found in MMM-voice.js - About 1 hr to fix

      Function checkCommands has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          checkCommands(data) {
        if (bytes.r[0].test(data) && bytes.r[1].test(data)) {
            this.sendSocketNotification('BYTES', bytes.a);
        } else if (/(WAKE)/g.test(data) && /(UP)/g.test(data)) {
            exec('/opt/vc/bin/tvservice -p && sudo chvt 6 && sudo chvt 7', null);
      Severity: Minor
      Found in node_helper.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function handleData has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          handleData(data) {
        if (typeof data === 'string') {
            if (this.config.debug) {
                console.log(`${this.name} has recognized: ${data}`);
                this.sendSocketNotification('DEBUG', data);
      Severity: Minor
      Found in node_helper.js - About 1 hr to fix

        Function getDom has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            getDom() {
        const wrapper = document.createElement('div');
        const voice = document.createElement('div');
        voice.classList.add('small', 'align-left');
        Severity: Minor
        Found in MMM-voice.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function arraysEqual has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            arraysEqual(a, b) {
        if (!(a instanceof Array) || !(b instanceof Array)) {
            return false;
        }
        Severity: Minor
        Found in node_helper.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Code block style
        Open

            ```
        Severity: Info
        Found in README.md by markdownlint

        Expected "MMM-voice-pulse" to be "mmm-voice-pulse" (value-keyword-case)
        Open

            -webkit-animation: MMM-voice-pulse 1s infinite;
        Severity: Minor
        Found in MMM-voice.css by stylelint

        value-keyword-case

        Specify lowercase or uppercase for keywords values.

        <!-- prettier-ignore --> 
        a { display: block; }
/**              ↑
 *    These values */

        This rule ignores <custom-idents> of known properties. Keyword values which are paired with non-properties (e.g. $vars and custom properties), and do not conform to the primary option, can be ignored using the ignoreKeywords: [] secondary option.

        The [fix option](../../../docs/user-guide/usage/options.md#fix) can automatically fix all of the problems reported by this rule.

        Severity
        Category
        Status
        Source
        Language