Sign upLogin

fey/php-project-lvl2

View on GitHub
Star

Showing 27 of 27 total issues

Method makeAstDiff has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function makeAstDiff($data1, $data2): array
{
    $makeDiff = function ($data1, $data2) use (&$makeDiff): array {
        $nodesNames = array_keys(array_merge((array)$data1, (array)$data2));
Severity: Minor
Found in src/Diff.php - About 1 hr to fix

    Method format has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function format(array $diff): string
{
    $format = function ($diff, $level) use (&$format) {
        return array_map(
            function ($node) use ($level, $format) {
    Severity: Minor
    Found in src/Formatters/Stylish.php - About 1 hr to fix

      Avoid excessively long variable names like $stringifyComplexValue. Keep variable name length under 20.
      Open

          $stringifyComplexValue = fn($complexValue, $level) => implode(
      Severity: Minor
      Found in src/Formatters/Stylish.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Method format has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function format(array $diff): string
{
    $format = function ($nodes, $nodePath) use (&$format) {
        return array_map(function ($node) use ($format, $nodePath) {
            [
      Severity: Minor
      Found in src/Formatters/Plain.php - About 1 hr to fix

        Method formatMessage has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function formatMessage(int $indentLevel, string $mark, string $nodeName, $value): string
{
    $stringifyComplexValue = fn($complexValue, $level) => implode(
        END_OF_LINE,
        [
        Severity: Minor
        Found in src/Formatters/Stylish.php - About 1 hr to fix

          There must be one USE keyword per declaration
          Open

          use const GenDiff\Diff\{ADDED, CHANGED, NESTED, REMOVED, UNCHANGED};
          Severity: Minor
          Found in src/Formatters/Stylish.php by phpcodesniffer

          There must be one USE keyword per declaration
          Open

          use const GenDiff\Diff\{ADDED, CHANGED, NESTED, REMOVED, UNCHANGED};
          Severity: Minor
          Found in src/Formatters/Plain.php by phpcodesniffer

          The method makeAstDiff uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                              } else {
                        return makeNode([
                                'type'     => CHANGED,
                                'name'     => $nodeName,
                                'oldValue' => $data1->$nodeName,
          Severity: Minor
          Found in src/Diff.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          Avoid unused local variables such as ''''.
          Open

                  compactCollection(flatten($format($diff, '')))
          Severity: Minor
          Found in src/Formatters/Plain.php by phpmd

          UnusedLocalVariable

          Since: 0.2

          Detects when a local variable is declared and/or assigned, but not used.

          Example

          class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

          Avoid using static access to class '\Symfony\Component\Yaml\Yaml' in method 'parseYaml'.
          Open

              return Yaml::parse($data, Yaml::PARSE_OBJECT_FOR_MAP);
          Severity: Minor
          Found in src/Parsers.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          The function makeAstDiff() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
          Open

          function makeAstDiff($data1, $data2): array
{
    $makeDiff = function ($data1, $data2) use (&$makeDiff): array {
        $nodesNames = array_keys(array_merge((array)$data1, (array)$data2));
          Severity: Minor
          Found in src/Diff.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          Only one argument is allowed per line in a multi-line function call
          Open

                          fn($value, $key) => formatMessage($indentLevel + 1, MARK_SPACES, $key, $value),
          Severity: Minor
          Found in src/Formatters/Stylish.php by phpcodesniffer

          Only one argument is allowed per line in a multi-line function call
          Open

                          fn($value, $key) => formatMessage($indentLevel + 1, MARK_SPACES, $key, $value),
          Severity: Minor
          Found in src/Formatters/Stylish.php by phpcodesniffer

          Only one argument is allowed per line in a multi-line function call
          Open

                          fn($value, $key) => formatMessage($indentLevel + 1, MARK_SPACES, $key, $value),
          Severity: Minor
          Found in src/Formatters/Stylish.php by phpcodesniffer

          syntax error, unexpected '=>' (T_DOUBLE_ARROW), expecting ']'
          Open

                  'yaml' => fn($content) => parseYaml($content),
          Severity: Critical
          Found in src/Parsers.php by phan

          syntax error, unexpected '=>' (T_DOUBLE_ARROW), expecting ']'
          Open

                          REMOVED   => fn() => sprintf("Property '%s' was removed", $ascendantNodePath),
          Severity: Critical
          Found in src/Formatters/Plain.php by phan

          Expected an indentation at 4 instead of at 2.
          Open

            -h --help                     Show this screen
          Severity: Minor
          Found in bin/gendiff by editorconfig

          Expected an indentation at 4 instead of at 2.
          Open

            --format <fmt>                Report format [default: stylish] Examples: stylish, plain, json
          Severity: Minor
          Found in bin/gendiff by editorconfig

          Expected an indentation at 8 instead of at 6.
          Open

                "ext-json": "*"
          Severity: Minor
          Found in composer.json by editorconfig

          Expected an indentation at 4 instead of at 2.
          Open

            gendiff [--format <fmt>] <firstFile> <secondFile>
          Severity: Minor
          Found in README.md by editorconfig
          Severity
          Category
          Status
          Source
          Language