fga-eps-mds/2019.1-unbrake

View on GitHub
unbrake-api/calibration/schema.py

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    calibration_command = graphene.Field(
        CalibrationCommandType,
        id=graphene.ID(),
        command_chanel_speed=graphene.Int(),
        actual_speed=graphene.Float(),
Severity: Major
Found in unbrake-api/calibration/schema.py and 1 other location - About 2 hrs to fix
unbrake-api/calibration/schema.py on lines 137..145

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    calibration_relations = graphene.Field(
        CalibrationRelationsType,
        id=graphene.ID(),
        transversal_selection_width=graphene.Int(),
        height_width_relation=graphene.Int(),
Severity: Major
Found in unbrake-api/calibration/schema.py and 1 other location - About 2 hrs to fix
unbrake-api/calibration/schema.py on lines 158..166

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    calibration_temperature = graphene.Field(
        CalibrationTemperatureType,
        id=graphene.ID(),
        acquisition_chanel=graphene.Int(),
        conversion_factor=graphene.Float(),
Severity: Major
Found in unbrake-api/calibration/schema.py and 2 other locations - About 1 hr to fix
unbrake-api/calibration/schema.py on lines 111..116
unbrake-api/calibration/schema.py on lines 120..125

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    calibration_force = graphene.Field(
        CalibrationForceType,
        id=graphene.ID(),
        acquisition_chanel=graphene.Int(),
        conversion_factor=graphene.Float(),
Severity: Major
Found in unbrake-api/calibration/schema.py and 2 other locations - About 1 hr to fix
unbrake-api/calibration/schema.py on lines 111..116
unbrake-api/calibration/schema.py on lines 149..154

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    calibration_vibration = graphene.Field(
        CalibrationVibrationType,
        id=graphene.ID(),
        acquisition_chanel=graphene.Int(),
        conversion_factor=graphene.Float(),
Severity: Major
Found in unbrake-api/calibration/schema.py and 2 other locations - About 1 hr to fix
unbrake-api/calibration/schema.py on lines 120..125
unbrake-api/calibration/schema.py on lines 149..154

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @login_required
    def resolve_calibration_temperature(self, info, **kwargs):
        '''
            Returning only one CalibrationTemperature by id
        '''
Severity: Major
Found in unbrake-api/calibration/schema.py and 8 other locations - About 1 hr to fix
unbrake-api/calibration/schema.py on lines 202..208
unbrake-api/calibration/schema.py on lines 217..224
unbrake-api/calibration/schema.py on lines 233..240
unbrake-api/calibration/schema.py on lines 265..272
unbrake-api/calibration/schema.py on lines 281..287
unbrake-api/configuration/schema.py on lines 207..214
unbrake-api/configuration/schema.py on lines 216..223
unbrake-api/testing/schema.py on lines 48..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @login_required
    def resolve_calibration_command(self, info, **kwargs):
        '''
            Returning only one CalibrationCommand by id
        '''
Severity: Major
Found in unbrake-api/calibration/schema.py and 8 other locations - About 1 hr to fix
unbrake-api/calibration/schema.py on lines 202..208
unbrake-api/calibration/schema.py on lines 217..224
unbrake-api/calibration/schema.py on lines 233..240
unbrake-api/calibration/schema.py on lines 249..256
unbrake-api/calibration/schema.py on lines 281..287
unbrake-api/configuration/schema.py on lines 207..214
unbrake-api/configuration/schema.py on lines 216..223
unbrake-api/testing/schema.py on lines 48..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @login_required
    def resolve_calibration_force(self, info, **kwargs):
        '''
            Returning only one CalibrationForce by id
        '''
Severity: Major
Found in unbrake-api/calibration/schema.py and 8 other locations - About 1 hr to fix
unbrake-api/calibration/schema.py on lines 217..224
unbrake-api/calibration/schema.py on lines 233..240
unbrake-api/calibration/schema.py on lines 249..256
unbrake-api/calibration/schema.py on lines 265..272
unbrake-api/calibration/schema.py on lines 281..287
unbrake-api/configuration/schema.py on lines 207..214
unbrake-api/configuration/schema.py on lines 216..223
unbrake-api/testing/schema.py on lines 48..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @login_required
    def resolve_calibration_speed(self, info, **kwargs):
        '''
            Returning only one CalibrationSpeed by id
        '''
Severity: Major
Found in unbrake-api/calibration/schema.py and 8 other locations - About 1 hr to fix
unbrake-api/calibration/schema.py on lines 202..208
unbrake-api/calibration/schema.py on lines 233..240
unbrake-api/calibration/schema.py on lines 249..256
unbrake-api/calibration/schema.py on lines 265..272
unbrake-api/calibration/schema.py on lines 281..287
unbrake-api/configuration/schema.py on lines 207..214
unbrake-api/configuration/schema.py on lines 216..223
unbrake-api/testing/schema.py on lines 48..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @login_required
    def resolve_calibration(self, info, **kwargs):
        '''
            Retunr a Calibration by id
        '''
Severity: Major
Found in unbrake-api/calibration/schema.py and 8 other locations - About 1 hr to fix
unbrake-api/calibration/schema.py on lines 202..208
unbrake-api/calibration/schema.py on lines 217..224
unbrake-api/calibration/schema.py on lines 233..240
unbrake-api/calibration/schema.py on lines 249..256
unbrake-api/calibration/schema.py on lines 265..272
unbrake-api/configuration/schema.py on lines 207..214
unbrake-api/configuration/schema.py on lines 216..223
unbrake-api/testing/schema.py on lines 48..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    @login_required
    def resolve_calibration_relations(self, info, **kwargs):
        '''
            Returning only one CalibrationRelations by id
        '''
Severity: Major
Found in unbrake-api/calibration/schema.py and 8 other locations - About 1 hr to fix
unbrake-api/calibration/schema.py on lines 202..208
unbrake-api/calibration/schema.py on lines 217..224
unbrake-api/calibration/schema.py on lines 249..256
unbrake-api/calibration/schema.py on lines 265..272
unbrake-api/calibration/schema.py on lines 281..287
unbrake-api/configuration/schema.py on lines 207..214
unbrake-api/configuration/schema.py on lines 216..223
unbrake-api/testing/schema.py on lines 48..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status