Sign upLogin

fga-eps-mds/2019.2-Vsign

View on GitHub
Star
backend/app/controllers/v1/users_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage

Line is too long. [83/80]
Open

    render json: { message: "Coudn't attach file", errors: e.message }, status: 500
Severity: Minor
Found in backend/app/controllers/v1/users_controller.rb by rubocop

Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
Open

  rescue Exception => e
    render json: { message: "Coudn't attach file", errors: e.message }, status: 500
Severity: Minor
Found in backend/app/controllers/v1/users_controller.rb by rubocop

This cop checks for rescue blocks targeting the Exception class.

Example:

# bad

begin
  do_something
rescue Exception
  handle_exception
end

Example:

# good

begin
  do_something
rescue ArgumentError
  handle_exception
end

Missing top-level class documentation comment.
Open

class V1::UsersController < V1Controller
Severity: Minor
Found in backend/app/controllers/v1/users_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use nested module/class definitions instead of compact style.
Open

class V1::UsersController < V1Controller
Severity: Minor
Found in backend/app/controllers/v1/users_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

There are no issues that match your filters.

Category
Status