Sign upLogin

fga-eps-mds/2019.2-Vsign

View on GitHub
Star

Showing 511 of 511 total issues

Extra empty line detected at method body end.
Open


  end
Severity: Minor
Found in backend/app/jobs/id_check_job.rb by rubocop

This cops checks if empty lines exist around the bodies of methods.

Example:

# good

def foo
  # ...
end

# bad

def bar

  # ...

end

Trailing whitespace detected.
Open

      ### Instead of the PUTS change for the contract status updating
Severity: Minor
Found in backend/app/jobs/extract_audio_text_job.rb by rubocop

Redundant curly braces around a hash parameter.
Open

    client = Aws::Rekognition::Client.new({
      region: Rails.application.credentials.dig(:aws, :region),
      credentials: Aws::Credentials.new(
        Rails.application.credentials.dig(:aws, :access_key_id),
        Rails.application.credentials.dig(:aws, :secret_access_key))
Severity: Minor
Found in backend/app/jobs/id_check_job.rb by rubocop

This cop checks for braces around the last parameter in a method call if the last parameter is a hash. It supports braces, no_braces and context_dependent styles.

Example: EnforcedStyle: braces

# The `braces` style enforces braces around all method
# parameters that are hashes.

# bad
some_method(x, y, a: 1, b: 2)

# good
some_method(x, y, {a: 1, b: 2})

Example: EnforcedStyle: no_braces (default)

# The `no_braces` style checks that the last parameter doesn't
# have braces around it.

# bad
some_method(x, y, {a: 1, b: 2})

# good
some_method(x, y, a: 1, b: 2)

Example: EnforcedStyle: context_dependent

# The `context_dependent` style checks that the last parameter
# doesn't have braces around it, but requires braces if the
# second to last parameter is also a hash literal.

# bad
some_method(x, y, {a: 1, b: 2})
some_method(x, y, {a: 1, b: 2}, a: 1, b: 2)

# good
some_method(x, y, a: 1, b: 2)
some_method(x, y, {a: 1, b: 2}, {a: 1, b: 2})

Use the return of the conditional for variable assignment and comparison.
Open

        if (text.detect_text == "PERMISSAO" || text.detect_text == "HAB")
          id_type = "CNH"
        else
          id_type = "RG"
        end
Severity: Minor
Found in backend/app/jobs/id_confirm_job.rb by rubocop

Trailing whitespace detected.
Open
Severity: Minor
Found in backend/app/jobs/id_check_job.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        if (text.detect_text == "PERMISSAO" || text.detect_text == "HAB")
Severity: Minor
Found in backend/app/jobs/id_confirm_job.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use self-assignment shorthand +=.
Open

          checked_items = checked_items + 1
Severity: Minor
Found in backend/app/jobs/id_check_job.rb by rubocop

This cop enforces the use the shorthand for self-assignment.

Example:

# bad
x = x + 1

# good
x += 1

Add an empty line after magic comments.
Open

include Rails.application.routes.url_helpers
Severity: Minor
Found in backend/app/models/contract.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Useless assignment to variable - response_text.
Open

    response_text = @client.detect_text  attrs
Severity: Minor
Found in backend/app/jobs/id_confirm_job.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Trailing whitespace detected.
Open

      error: {
Severity: Minor
Found in backend/app/controllers/graphql_controller.rb by rubocop

Line is too long. [81/80]
Open

          bucket: Rails.application.credentials[Rails.env.to_sym][:aws][:bucket],
Severity: Minor
Found in backend/app/jobs/id_confirm_job.rb by rubocop

Redundant self detected.
Open

        buttonURL: login_by_token_path(token: self.token)
Severity: Minor
Found in backend/app/models/contract.rb by rubocop

This cop checks for redundant uses of self.

The usage of self is only needed when:

  • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

  • Calling an attribute writer to prevent an local variable assignment.

Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

Note we allow uses of self with operators because it would be awkward otherwise.

Example:

# bad
def foo(bar)
  self.baz
end

# good
def foo(bar)
  self.bar  # Resolves name clash with the argument.
end

def foo
  bar = 1
  self.bar  # Resolves name clash with the local variable.
end

def foo
  %w[x y z].select do |bar|
    self.bar == bar  # Resolves name clash with argument of the block.
  end
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      "d-977dd6915e8a430bbed0ab92c9a4421a"
Severity: Minor
Found in backend/app/models/contract.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        language_code: "pt-BR",
Severity: Minor
Found in backend/app/jobs/extract_audio_text_job.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Useless assignment to variable - user_rg. Did you mean user_cpf?
Open

    user_rg = @content.rg
Severity: Minor
Found in backend/app/jobs/id_check_job.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        elsif detections.text.include?("user_rg")
Severity: Minor
Found in backend/app/jobs/id_check_job.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Put one space between the method name and the first argument.
Open

    response_text = @client.detect_text  attrs
Severity: Minor
Found in backend/app/jobs/id_confirm_job.rb by rubocop

Checks that exactly one space is used between a method name and the first argument for method calls without parentheses.

Alternatively, extra spaces can be added to align the argument with something on a preceding or following line, if the AllowForAlignment config parameter is true.

Example:

# bad
something  x
something   y, z
something'hello'

# good
something x
something y, z
something 'hello'

Useless assignment to variable - response_text.
Open

    response_text = text_detection.each do |text|
Severity: Minor
Found in backend/app/jobs/id_confirm_job.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Line is too long. [129/80]
Open

      if (labels.name == "Document" || labels.name == "License" || labels.name == "Driving License" || labels.name == "Id Cards")
Severity: Minor
Found in backend/app/jobs/id_confirm_job.rb by rubocop

Line is too long. [100/80]
Open

      if (text.detect_text == "CPF" && text.detect_text == "NOME" || text.detect_text == "FILIACAO")
Severity: Minor
Found in backend/app/jobs/id_confirm_job.rb by rubocop
Severity
Category
Status
Source
Language