Sign upLogin

fga-eps-mds/2019.2-Vsign

View on GitHub
Star

Showing 511 of 511 total issues

Missing top-level class documentation comment.
Open

class CreateContracts < ActiveRecord::Migration[5.2]
Severity: Minor
Found in backend/db/migrate/20190920042643_create_contracts.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [88/80]
Open

    contract = Contract.find_or_create_by(company: @company, order: order) do |contract|
Severity: Minor
Found in backend/app/controllers/v1/contracts_controller.rb by rubocop

Trailing whitespace detected.
Open

#     user_id: User.all.sample.id,
Severity: Minor
Found in backend/db/seeds.rb by rubocop

Line is too long. [86/80]
Open

# from scratch. The latter is a flawed and unsustainable approach (the more migrations
Severity: Minor
Found in backend/db/schema.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    t.bigint "blob_id", null: false
Severity: Minor
Found in backend/db/schema.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    t.index ["company_id"], name: "index_scripts_on_company_id"
Severity: Minor
Found in backend/db/schema.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Missing top-level class documentation comment.
Open

class ChangeScriptTypeOnContract < ActiveRecord::Migration[5.2]
Severity: Minor
Found in backend/db/migrate/20191102183305_change_script_type_on_contract.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

class AddWebhookToScripts < ActiveRecord::Migration[5.2]
Severity: Minor
Found in backend/db/migrate/20191111200657_add_webhook_to_scripts.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

include is used at the top level. Use inside class or module.
Open

include FileUtils
Severity: Minor
Found in backend/bin/update by rubocop

This cop checks that include, extend and prepend exists at the top level. Using these at the top level affects the behavior of Object. There will not be using include, extend and prepend at the top level. Let's use it inside class or module.

Example:

# bad
include M

class C
end

# bad
extend M

class C
end

# bad
prepend M

class C
end

# good
class C
  include M
end

# good
class C
  extend M
end

# good
class C
  prepend M
end

Missing space after #.
Open

#gem 'aws-sdk-s3', '~>1'
Severity: Minor
Found in backend/Gemfile by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Line is too long. [84/80]
Open

  # :database      = Support basic authentication with authentication key + password
Severity: Minor
Found in backend/config/initializers/devise.rb by rubocop

Line is too long. [84/80]
Open

  # unconfirmed_email column, and copied to email column on successful confirmation.
Severity: Minor
Found in backend/config/initializers/devise.rb by rubocop

Line is too long. [85/80]
Open

  # :failed_attempts = Locks an account after a number of failed attempts to sign in.
Severity: Minor
Found in backend/config/initializers/devise.rb by rubocop

Line is too long. [100/80]
Open

# Use Rack CORS for handling Cross-Origin Resource Sharing (CORS), making cross-origin AJAX possible
Severity: Minor
Found in backend/Gemfile by rubocop

Missing top-level class documentation comment.
Open

  class Application < Rails::Application
Severity: Minor
Found in backend/config/application.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [85/80]
Open

# Specifies the `port` that Puma will listen on to receive requests; default is 3000.
Severity: Minor
Found in backend/config/puma.rb by rubocop

Line is too long. [81/80]
Open

  # It can be set to an array that will enable params authentication only for the
Severity: Minor
Found in backend/config/initializers/devise.rb by rubocop

Line is too long. [82/80]
Open

  # Limiting the stretches to just one in testing will increase the performance of
Severity: Minor
Found in backend/config/initializers/devise.rb by rubocop

Line is too long. [81/80]
Open

  # When using Devise inside an engine, let's call it `MyEngine`, and this engine
Severity: Minor
Found in backend/config/initializers/devise.rb by rubocop

unexpected token tLABEL (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
Open

      host: 'staging.dar0d46dq2rcb.amplifyapp.com',
Severity: Minor
Found in backend/config/environments/staging.rb by rubocop
Severity
Category
Status
Source
Language