Sign upLogin

fga-gpp-mds/2017.1-Escola-X

View on GitHub
Star

Showing 3,213 of 3,213 total issues

Tab detected.
Open

      if ( is_principal? )
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Space inside parentheses detected.
Open

    if ( is_principal? )
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Tab detected.
Open

    def error_500
Severity: Minor
Found in app/controllers/errors_controller.rb by rubocop

Tab detected.
Open

      if ( is_principal? )
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Space inside parentheses detected.
Open

    if ( is_employee? )
Severity: Minor
Found in app/controllers/teachers_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Tab detected.
Open

            @subject = Subject.find(params[:id])
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Tab detected.
Open

            if ( @teacher.nil? )
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Align the elements of a hash literal if they span more than one line.
Open

                      classroom_id: alumn.classroom_id)
Severity: Minor
Found in app/controllers/grades_controller.rb by rubocop

Check that the keys, separators, and values of a multi-line hash literal are aligned according to configuration. The configuration options are:

- key (left align keys)
- separator (align hash rockets and colons, right align keys)
- table (left align keys, hash rockets, and values)

The treatment of hashes passed as the last argument to a method call can also be configured. The options are:

- always_inspect
- always_ignore
- ignore_implicit (without curly braces)
- ignore_explicit (with curly braces)

Example:

# EnforcedHashRocketStyle: key (default)
# EnforcedColonStyle: key (default)

# good
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}

# bad
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Example:

# EnforcedHashRocketStyle: separator
# EnforcedColonStyle: separator

#good
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}
{
  :foo => bar,
  :ba  => baz
}

Example:

# EnforcedHashRocketStyle: table
# EnforcedColonStyle: table

#good
{
  foo: bar,
  ba:  baz
}
{
  :foo => bar,
  :ba  => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Space inside parentheses detected.
Open

    if ( is_employee? )
Severity: Minor
Found in app/controllers/notifications_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Tab detected.
Open

                render 'edit'
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Space missing after colon.
Open

      if !(Grade.where(alumn_id:alumn.id).where(subject_id: subject.id).exists?)
Severity: Minor
Found in app/controllers/grades_controller.rb by rubocop

Checks for colon (:) not followed by some kind of space. N.B. this cop does not handle spaces after a ternary operator, which are instead handled by Layout/SpaceAroundOperators.

Example:

# bad
def f(a:, b:2); {a:3}; end

# good
def f(a:, b: 2); {a: 3}; end

Space inside parentheses detected.
Open

    params.require(:notification).permit( :title,
Severity: Minor
Found in app/controllers/notifications_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Tab detected.
Open

            @teacher = Teacher.find_by_registry(params[:teacher_registry])
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Favor unless over if for negative conditions.
Open

      if !(Grade.where(alumn_id:alumn.id).where(subject_id: subject.id).exists?)
        @grade = Grade.new(alumn_id: alumn.id, subject_id: subject.id,
                      classroom_id: alumn.classroom_id)
        @grade.save
      end
Severity: Minor
Found in app/controllers/grades_controller.rb by rubocop

Checks for uses of if with a negated condition. Only ifs without else are considered. There are three different styles:

- both
- prefix
- postfix

Example: EnforcedStyle: both (default)

# enforces `unless` for `prefix` and `postfix` conditionals

# bad

if !foo
  bar
end

# good

unless foo
  bar
end

# bad

bar if !foo

# good

bar unless foo

Example: EnforcedStyle: prefix

# enforces `unless` for just `prefix` conditionals

# bad

if !foo
  bar
end

# good

unless foo
  bar
end

# good

bar if !foo

Example: EnforcedStyle: postfix

# enforces `unless` for just `postfix` conditionals

# bad

bar if !foo

# good

bar unless foo

# good

if !foo
  bar
end

Tab detected.
Open

                redirect_to @subject
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Don't use parentheses around a method call.
Open

    if ( is_employee? )
Severity: Minor
Found in app/controllers/notifications_controller.rb by rubocop

This cop checks for redundant parentheses.

Example:

# bad
(x) if ((y.z).nil?)

# good
x if y.z.nil?

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        render "grades/index"
Severity: Minor
Found in app/controllers/grades_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Don't use parentheses around a method call.
Open

      if ( @notification.update(notification_params) )
Severity: Minor
Found in app/controllers/notifications_controller.rb by rubocop

This cop checks for redundant parentheses.

Example:

# bad
(x) if ((y.z).nil?)

# good
x if y.z.nil?

Tab detected.
Open

            else
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Align else with if.
Open

    else
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cops checks the alignment of else keywords. Normally they should be aligned with an if/unless/while/until/begin/def keyword, but there are special cases when they should follow the same rules as the alignment of end.

Example:

# bad
if something
  code
 else
  code
end

# bad
if something
  code
 elsif something
  code
end

# good
if something
  code
else
  code
end
Severity
Category
Status
Source
Language