Sign upLogin

fga-gpp-mds/2017.1-Escola-X

View on GitHub
Star

Showing 3,213 of 3,213 total issues

Use 2 (not 1) spaces for indentation.
Open

    driver.get('http://localhost:3000/teachers/4/teacher_classroom_subjects/1')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 1) spaces for indentation.
Open

    notification_title_edit = driver.find_element(:name, 'notification[title]')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 1) spaces for indentation.
Open

    grade3 = driver.find_element(:name, 'grade[grade_03]')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Tab detected.
Open

    senha = driver.find_element(:name, 'password')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    entrar.click
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    senha = driver.find_element(:name, 'password')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    alumn_phone.send_keys '6198310481'
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    cpfUser = driver.find_element(:name, 'secretary[employee_cpf]')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    turnUser.send_keys "Integral"
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    gender.click
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    cpfUser = driver.find_element(:name, 'teacher[employee_cpf]')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    admissionDate = driver.find_element(:name, 'teacher[admission_date]')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    parent_name = driver.find_element(:name, 'parent[name]')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    subject_name.send_keys "Arrecadar fundos pra formatura do pessoal de Softy e de Aero"
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    salvar.click
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    sair.click
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

            else
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

end at 35, 4 is not aligned with if at 30, 3.
Open

    end
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cop checks whether the end keywords are aligned properly.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

Example: EnforcedStyleAlignWith: keyword (default)

# bad

variable = if true
    end

# good

variable = if true
           end

Example: EnforcedStyleAlignWith: variable

# bad

variable = if true
    end

# good

variable = if true
end

Example: EnforcedStyleAlignWith: startofline

# bad

variable = if true
    end

# good

puts(if true
end)

Use || instead of or.
Open

      if ( is_principal? or is_teacher? )
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

Example: EnforcedStyle: always (default)

# bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

Example: EnforcedStyle: conditionals

# bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

Don't use parentheses around a method call.
Open

            if ( @teacher.nil? )
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cop checks for redundant parentheses.

Example:

# bad
(x) if ((y.z).nil?)

# good
x if y.z.nil?
Severity
Category
Status
Source
Language