Sign upLogin

fga-gpp-mds/2017.1-Escola-X

View on GitHub
Star

Showing 3,213 of 3,213 total issues

Tab detected.
Open

    alumn_phone = driver.find_element(:name, 'alumn[phone]')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    matriculaUser.send_keys "147258"
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    senhaUser = driver.find_element(:name, 'teacher[password]')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    birthDate = driver.find_element(:name, 'teacher[birth_date]')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    parent_cpf = driver.find_element(:name, 'parent[parent_cpf]')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    subject_class.send_keys '3'
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    strike_description = driver.find_element(:name, 'strike[description_strike]')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    shift.send_keys "Vespertino"
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    salvar = driver.find_element(:name, 'button')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    driver.get('http://localhost:3000/alumns/1')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

                @classroom_subject = ClassroomSubject.new
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

                    flash[:success] = "Matéria adicionada com sucesso"
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Extra empty line detected at class body beginning.
Open


  # Include RMagick or MiniMagick support:
Severity: Minor
Found in app/uploaders/image_uploader.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Extra empty line detected at class body end.
Open


end
Severity: Minor
Found in app/uploaders/image_uploader.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Line is too long. [81/80]
Open

  # Avoid using model.id or version_name here, see uploader/store.rb for details.
Severity: Minor
Found in app/uploaders/image_uploader.rb by rubocop

Missing top-level class documentation comment.
Open

class ImageUploader < CarrierWave::Uploader::Base
Severity: Minor
Found in app/uploaders/image_uploader.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [83/80]
Open

# Description: Controller used to communicate with the proprietary view of subjects
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Use 2 (not 1) spaces for indentation.
Open

    senhaUser = driver.find_element(:name, 'secretary[password]')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Don't use parentheses around the condition of an if.
Open

      if ( is_principal? )
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

Use 2 (not 1) spaces for indentation.
Open

    phoneUser = driver.find_element(:name, 'teacher[phone]')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end
Severity
Category
Status
Source
Language