Sign upLogin

fga-gpp-mds/2017.1-Escola-X

View on GitHub
Star

Showing 3,213 of 3,213 total issues

Line is too long. [82/80]
Open

And (/^I fill in field parent "Endereço" with "Magnífica Mansão no Pedregal"$/) do
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Line is too long. [87/80]
Open

    notification_text_edit = driver.find_element(:name, 'notification[notification_text]')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    login.send_keys "363636"
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    principal_password.send_keys "12345678"
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [83/80]
Open

  config.vm.provision :shell, path: "vagrant_config/install-rvm.sh", args: "stable"
Severity: Minor
Found in Vagrantfile by rubocop

Space inside } missing.
Open

    Cucumber::Rake::Task.new({:ok => 'test:prepare'}, 'Run features that should pass') do |t|
Severity: Minor
Found in lib/tasks/cucumber.rake by rubocop

Checks that braces used for hash literals have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: space

# The `space` style enforces that hash literals have
# surrounding space.

# bad
h = {a: 1, b: 2}

# good
h = { a: 1, b: 2 }

Example: EnforcedStyle: no_space

# The `no_space` style enforces that hash literals have
# no surrounding space.

# bad
h = { a: 1, b: 2 }

# good
h = {a: 1, b: 2}

Example: EnforcedStyle: compact

# The `compact` style normally requires a space inside
# hash braces, with the exception that successive left
# braces or right braces are collapsed together in nested hashes.

# bad
h = { a: { b: 2 } }

# good
h = { a: { b: 2 }}

Line is too long. [107/80]
Open

  # In case we don't have the generic Rails test:prepare hook, append a no-op task that we can depend upon.
Severity: Minor
Found in lib/tasks/cucumber.rake by rubocop

Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem byebug should appear before rspec-rails.
Open

  gem 'byebug', platform: :mri
Severity: Minor
Found in Gemfile by rubocop

Gems should be alphabetically sorted within groups.

Example:

# bad
gem 'rubocop'
gem 'rspec'

# good
gem 'rspec'
gem 'rubocop'

# good
gem 'rubocop'

gem 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
gem 'rubocop'
# For tests
gem 'rspec'

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

gem "paperclip", "~> 3.0"
Severity: Minor
Found in Gemfile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Align the elements of a hash literal if they span more than one line.
Open

       as:'teacher_grades'
Severity: Minor
Found in config/routes.rb by rubocop

Check that the keys, separators, and values of a multi-line hash literal are aligned according to configuration. The configuration options are:

- key (left align keys)
- separator (align hash rockets and colons, right align keys)
- table (left align keys, hash rockets, and values)

The treatment of hashes passed as the last argument to a method call can also be configured. The options are:

- always_inspect
- always_ignore
- ignore_implicit (without curly braces)
- ignore_explicit (with curly braces)

Example:

# EnforcedHashRocketStyle: key (default)
# EnforcedColonStyle: key (default)

# good
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}

# bad
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Example:

# EnforcedHashRocketStyle: separator
# EnforcedColonStyle: separator

#good
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}
{
  :foo => bar,
  :ba  => baz
}

Example:

# EnforcedHashRocketStyle: table
# EnforcedColonStyle: table

#good
{
  foo: bar,
  ba:  baz
}
{
  :foo => bar,
  :ba  => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Extra blank line detected.
Open


  get 'classroom/:id/classroom_subjects', to:'subjects#classroom_subjects', as:'classroom_subjects'
Severity: Minor
Found in config/routes.rb by rubocop

This cops checks for two or more consecutive blank lines.

Example:

# bad - It has two empty lines.
some_method
# one empty line
# two empty lines
some_method

# good
some_method
# one empty line
some_method

Extra blank line detected.
Open


  root 'sessions#new'
Severity: Minor
Found in config/routes.rb by rubocop

This cops checks for two or more consecutive blank lines.

Example:

# bad - It has two empty lines.
some_method
# one empty line
# two empty lines
some_method

# good
some_method
# one empty line
some_method

Space missing after colon.
Open

  put 'employees/:id/edit_password', to:'employees#update_password_employee'
Severity: Minor
Found in config/routes.rb by rubocop

Checks for colon (:) not followed by some kind of space. N.B. this cop does not handle spaces after a ternary operator, which are instead handled by Layout/SpaceAroundOperators.

Example:

# bad
def f(a:, b:2); {a:3}; end

# good
def f(a:, b: 2); {a: 3}; end

Space missing after colon.
Open

  get 'classroom/:id/subject/:subject_id/grades', to:'grades#set_grades', as:'set_grades'
Severity: Minor
Found in config/routes.rb by rubocop

Checks for colon (:) not followed by some kind of space. N.B. this cop does not handle spaces after a ternary operator, which are instead handled by Layout/SpaceAroundOperators.

Example:

# bad
def f(a:, b:2); {a:3}; end

# good
def f(a:, b: 2); {a: 3}; end

Space missing after colon.
Open

  get 'teachers/:teacher_id/teacher_classroom_subjects/:classroom_id/teacher_grades/:subject_id', to:'teachers#teacher_grades',
Severity: Minor
Found in config/routes.rb by rubocop

Checks for colon (:) not followed by some kind of space. N.B. this cop does not handle spaces after a ternary operator, which are instead handled by Layout/SpaceAroundOperators.

Example:

# bad
def f(a:, b:2); {a:3}; end

# good
def f(a:, b: 2); {a: 3}; end

Tab detected.
Open

    driver.get('http://localhost:3000/parents/new')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    driver.get('http://localhost:3000/parents')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    driver.get('http://localhost:3000/notifications/1')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    driver.get('http://localhost:3000/notifications')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop

Tab detected.
Open

    driver.get('http://localhost:3000/notifications')
Severity: Minor
Found in features/step_definitions/escolaX.rb by rubocop
Severity
Category
Status
Source
Language