fga-gpp-mds/2017.1-Escola-X

View on GitHub

Showing 3,213 of 3,213 total issues

Tab detected.
Open

         day = Time.current.day.to_s
Severity: Minor
Found in app/helpers/reader_helper.rb by rubocop

Don't use parentheses around the condition of an elsif.
Open

      elsif ( !(@current_user = Parent.find_by_authorization_token(cookies[:authorization_token])).nil? )
Severity: Minor
Found in app/helpers/sessions_helper.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

Trailing whitespace detected.
Open

    
Severity: Minor
Found in app/helpers/reader_helper.rb by rubocop

Don't use parentheses around the condition of an if.
Open

    if ( (logged_in?) and (current_user.is_a?(Parent)))
Severity: Minor
Found in app/helpers/sessions_helper.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

Tab detected.
Open

        for alumn in alumns 
Severity: Minor
Found in app/helpers/school_misses_helper.rb by rubocop

Don't use parentheses around an unary operation.
Open

      elsif ( !(@current_user = Alumn.find_by_authorization_token(cookies[:authorization_token])).nil? )
Severity: Minor
Found in app/helpers/sessions_helper.rb by rubocop

This cop checks for redundant parentheses.

Example:

# bad
(x) if ((y.z).nil?)

# good
x if y.z.nil?

Extra empty line detected at method body beginning.
Open


    found = false
Severity: Minor
Found in app/helpers/sessions_helper.rb by rubocop

This cops checks if empty lines exist around the bodies of methods.

Example:

# good

def foo
  # ...
end

# bad

def bar

  # ...

end

Redundant return detected.
Open

      return true
Severity: Minor
Found in app/helpers/sessions_helper.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Use snake_case for method names.
Open

    def mountCurrentDate() 
Severity: Minor
Found in app/helpers/reader_helper.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Extra empty line detected at method body beginning.
Open


    found = false
Severity: Minor
Found in app/helpers/sessions_helper.rb by rubocop

This cops checks if empty lines exist around the bodies of methods.

Example:

# good

def foo
  # ...
end

# bad

def bar

  # ...

end

Redundant return detected.
Open

    return found
Severity: Minor
Found in app/helpers/sessions_helper.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Space inside parentheses detected.
Open

      elsif ( !(@current_user = Alumn.find_by_authorization_token(cookies[:authorization_token])).nil? )
Severity: Minor
Found in app/helpers/sessions_helper.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Freeze mutable objects assigned to constants.
Open

    SPACE_TRACE_SPACE = "-"
Severity: Minor
Found in app/helpers/reader_helper.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Space inside parentheses detected.
Open

    if ( current_user.nil? )
Severity: Minor
Found in app/helpers/sessions_helper.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Missing top-level module documentation comment.
Open

module GradeHistoriesHelper

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Do not use semicolons to terminate expressions.
Open

    ADJUSTING_FUSE_TO_BRAZILIAN = 3;
Severity: Minor
Found in app/helpers/reader_helper.rb by rubocop

This cop checks for multiple expressions placed on the same line. It also checks for lines terminated with a semicolon.

Example:

# bad
foo = 1; bar = 2;
baz = 3;

# good
foo = 1
bar = 2
baz = 3

Space inside parentheses detected.
Open

    if ( alumn.parent_id == current_user.id and current_user.is_a?(Parent))
Severity: Minor
Found in app/helpers/sessions_helper.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Missing space after #.
Open

        #nothing to do

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Tab detected.
Open

        end
Severity: Minor
Found in app/helpers/school_misses_helper.rb by rubocop

Use || instead of or.
Open

    return ( is_principal? or is_secretary? or is_teacher? )
Severity: Minor
Found in app/helpers/sessions_helper.rb by rubocop

This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

Example: EnforcedStyle: always (default)

# bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

Example: EnforcedStyle: conditionals

# bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end
Severity
Category
Status
Source
Language