Sign upLogin

fga-gpp-mds/2017.1-Escola-X

View on GitHub
Star

Showing 3,213 of 3,213 total issues

Tab detected.
Open

    def give_presence_to_alumn(date , alumn)
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Use 2 (not 1) spaces for indentation.
Open

        if ( is_principal? )
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 6) spaces for indentation.
Open

              redirect_to "/errors/error_500"
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Tab detected.
Open

            for school_miss in school_misses
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Space after keyword if is missing.
Open

            if( @suspension.destroy )
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Checks the spacing around the keywords.

Example:

# bad
something 'test'do|x|
end

while(something)
end

something = 123if test

# good
something 'test' do |x|
end

while (something)
end

something = 123 if test

Tab detected.
Open

    ZERO = "0";
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Space inside parentheses detected.
Open

        if( is_principal? )
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Tab detected.
Open

         end
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Tab detected.
Open

    def new
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Trailing whitespace detected.
Open

            date = mountCurrentDate()
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Tab detected.
Open

        else
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Trailing whitespace detected.
Open
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Tab detected.
Open

                    render 'suspensions/new'
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Tab detected.
Open

        else
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Use && instead of and.
Open

        if ( logged_in? and is_principal? )
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

Example: EnforcedStyle: always (default)

# bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

Example: EnforcedStyle: conditionals

# bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

Tab detected.
Open

                    redirect_to users_path
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Don't use parentheses around the condition of an if.
Open

         if (day.length == SINGLE_CHAR)
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

Tab detected.
Open

        else
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Use || instead of or.
Open

    if ( is_employee? or verify_alumn(id) or is_son?(id) )
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

Example: EnforcedStyle: always (default)

# bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

Example: EnforcedStyle: conditionals

# bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

              redirect_to "/errors/error_500"
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"
Severity
Category
Status
Source
Language