Sign upLogin

fga-gpp-mds/2017.1-Escola-X

View on GitHub
Star

Showing 3,213 of 3,213 total issues

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

        if ( logged_in? )
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Tab detected.
Open
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Don't use parentheses around the condition of an if.
Open

        if ( is_principal? )
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

Don't use parentheses around the condition of an if.
Open

        if ( logged_in? )
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

Tab detected.
Open

        if (school_misses != nil)
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Space inside parentheses detected.
Open

    if ( is_parent? )
Severity: Minor
Found in app/controllers/alumns_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Tab detected.
Open

                else
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Space inside parentheses detected.
Open

    if ( is_employee? or is_son?(id) or verify_alumn(id) )
Severity: Minor
Found in app/controllers/alumns_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Space inside parentheses detected.
Open

    if ( is_principal? )
Severity: Minor
Found in app/controllers/alumns_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Tab detected.
Open
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Don't use parentheses around a method call.
Open

        elsif (params[:search].blank?)
Severity: Minor
Found in app/controllers/alumns_controller.rb by rubocop

This cop checks for redundant parentheses.

Example:

# bad
(x) if ((y.z).nil?)

# good
x if y.z.nil?

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        render action: "../users/edit_password"
Severity: Minor
Found in app/controllers/alumns_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Tab detected.
Open

         year = Time.current.year.to_s
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Align the parameters of a method call if they span more than one line.
Open

                                       :gender,
Severity: Minor
Found in app/controllers/secretaries_controller.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Tab detected.
Open

    end
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Inconsistent indentation detected.
Open

  def create
    if ( is_principal? )
            @shifts = Shift.all
      @secretary = Secretary.new(secretary_params)
      if (@secretary.save)
Severity: Minor
Found in app/controllers/secretaries_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Use 2 (not 1) spaces for indentation.
Open

      params.require(:secretary).permit( :employee_cpf,
Severity: Minor
Found in app/controllers/secretaries_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Tab detected.
Open

    include SessionsHelper
Severity: Minor
Found in app/controllers/secretaries_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

    if ( is_principal? )
Severity: Minor
Found in app/controllers/secretaries_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      redirect_to "/errors/error_500"
Severity: Minor
Found in app/controllers/secretaries_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"
Severity
Category
Status
Source
Language