Sign upLogin

fga-gpp-mds/2017.1-Escola-X

View on GitHub
Star

Showing 3,213 of 3,213 total issues

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

    if ( is_employee? )
Severity: Minor
Found in app/controllers/employees_controller.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Tab detected.
Open

                                       :shift,
Severity: Minor
Found in app/controllers/secretaries_controller.rb by rubocop

Don't use parentheses around the condition of an if.
Open

        if ( is_employee? )
Severity: Minor
Found in app/controllers/employees_controller.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

Use || instead of or.
Open

    if ( is_principal? or is_secretary? )
Severity: Minor
Found in app/controllers/secretaries_controller.rb by rubocop

This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

Example: EnforcedStyle: always (default)

# bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

Example: EnforcedStyle: conditionals

# bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

Don't use parentheses around the condition of an if.
Open

    if ( is_employee? )
Severity: Minor
Found in app/controllers/employees_controller.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

Don't use parentheses around a method call.
Open

    if ( is_principal? )
Severity: Minor
Found in app/controllers/secretaries_controller.rb by rubocop

This cop checks for redundant parentheses.

Example:

# bad
(x) if ((y.z).nil?)

# good
x if y.z.nil?

Don't use parentheses around the condition of an if.
Open

    if ( is_principal? )
Severity: Minor
Found in app/controllers/employees_controller.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

Don't use parentheses around a method call.
Open

    if ( is_employee? )
Severity: Minor
Found in app/controllers/employees_controller.rb by rubocop

This cop checks for redundant parentheses.

Example:

# bad
(x) if ((y.z).nil?)

# good
x if y.z.nil?

Tab detected.
Open

                                                                            :employee_cpf,
Severity: Minor
Found in app/controllers/principal_controller.rb by rubocop

Keep a blank line before and after private.
Open

    private
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Access modifiers should be surrounded by blank lines.

Example:

# bad
class Foo
  def bar; end
  private
  def baz; end
end

# good
class Foo
  def bar; end

  private

  def baz; end
end

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

    if ( is_principal? )
Severity: Minor
Found in app/controllers/principal_controller.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Tab detected.
Open

            bar_code = params[:bar_code]
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Align the parameters of a method call if they span more than one line.
Open

                               :alumn_id,
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Tab detected.
Open

              redirect_to "/errors/error_500"
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Tab detected.
Open

    end
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Use 2 (not 0) spaces for indentation.
Open

    id = params[:alumn_id]
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Tab detected.
Open

         #minute = Time.current.min .to_s
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Use 2 (not 1) spaces for indentation.
Open

            @@alumn = Alumn.find(params[:alumn_id])
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Tab detected.
Open

         if (month.length == SINGLE_CHAR)
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Use 2 (not 1) spaces for indentation.
Open

            @suspension = Suspension.find(params[:id])
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end
Severity
Category
Status
Source
Language