Sign upLogin

fga-gpp-mds/2017.1-Escola-X

View on GitHub
Star

Showing 3,213 of 3,213 total issues

Don't use parentheses around a method call.
Open

    if ( is_employee? )
Severity: Minor
Found in app/controllers/users_controller.rb by rubocop

This cop checks for redundant parentheses.

Example:

# bad
(x) if ((y.z).nil?)

# good
x if y.z.nil?

Use 2 (not 1) spaces for indentation.
Open

                    flash[:alert] = "Suspensão excluída com sucesso"
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Tab detected.
Open

            @alumn = Alumn.find_by_id(@suspension.alumn_id)
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Tab detected.
Open

            if( @suspension.save )
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Tab detected.
Open

                    redirect_to alumn_path(@alumn)
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Tab detected.
Open

            end
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Use || instead of or.
Open

    if is_principal? or is_secretary?
Severity: Minor
Found in app/controllers/grade_histories_controller.rb by rubocop

This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

Example: EnforcedStyle: always (default)

# bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

Example: EnforcedStyle: conditionals

# bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

Use 2 (not 1) spaces for indentation.
Open

                flash[:notice] = "Suspensão alterada com sucesso"
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Tab detected.
Open

         day = Time.current.day.to_s
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Tab detected.
Open

                end
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Tab detected.
Open

    else
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Inconsistent indentation detected.
Open

          flash.now[:feedback_warning] = "Digite algo para pesquisar!"
Severity: Minor
Found in app/controllers/alumns_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Tab detected.
Open

                redirect_to suspension_path(@suspension)
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Space inside parentheses detected.
Open

    if ( is_principal? )
Severity: Minor
Found in app/controllers/alumns_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Line is too long. [86/80]
Open

      if ( !(is_parent_related_to_alumn?(@alumn) or is_me?(@alumn) or is_principal?) )
Severity: Minor
Found in app/controllers/alumns_controller.rb by rubocop

Tab detected.
Open

        if( is_principal? )
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

end at 16, 2 is not aligned with def at 7, 1.
Open

  end
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

This cop checks whether the end keywords of method definitions are aligned properly.

Two modes are supported through the EnforcedStyleAlignWith configuration parameter. If it's set to start_of_line (which is the default), the end shall be aligned with the start of the line where the def keyword is. If it's set to def, the end shall be aligned with the def keyword.

Example: EnforcedStyleAlignWith: startofline (default)

# bad

private def foo
            end

# good

private def foo
end

Example: EnforcedStyleAlignWith: def

# bad

private def foo
            end

# good

private def foo
        end

Don't use parentheses around the condition of an if.
Open

    if ( is_principal? )
Severity: Minor
Found in app/controllers/alumns_controller.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

Tab detected.
Open

    end
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

Don't use parentheses around the condition of an if.
Open

    if ( is_employee? or verify_alumn(id) or is_son?(id) )
Severity: Minor
Found in app/controllers/suspensions_controller.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end
Severity
Category
Status
Source
Language