Sign upLogin

fga-gpp-mds/2017.1-Escola-X

View on GitHub
Star

Showing 3,213 of 3,213 total issues

Tab detected.
Open

                    # nothing to do in here
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Tab detected.
Open

             month = ZERO + month
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

Don't use parentheses around the condition of an if.
Open

        if ( logged_in? and is_principal? )
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

Don't use parentheses around the condition of an if.
Open

         if (month.length == SINGLE_CHAR)
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

Do not use semicolons to terminate expressions.
Open

    ADJUSTING_FUSE_TO_BRAZILIAN = 3;
Severity: Minor
Found in app/controllers/reader_controller.rb by rubocop

This cop checks for multiple expressions placed on the same line. It also checks for lines terminated with a semicolon.

Example:

# bad
foo = 1; bar = 2;
baz = 3;

# good
foo = 1
bar = 2
baz = 3

Tab detected.
Open

    end
Severity: Minor
Found in app/controllers/errors_controller.rb by rubocop

Align the parameters of a method call if they span more than one line.
Open

        :class_level,:teacher_id,:classroom_id,:subject_id, :classroom_grade_id)
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Align else with if.
Open

    else
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cops checks the alignment of else keywords. Normally they should be aligned with an if/unless/while/until/begin/def keyword, but there are special cases when they should follow the same rules as the alignment of end.

Example:

# bad
if something
  code
 else
  code
end

# bad
if something
  code
 elsif something
  code
end

# good
if something
  code
else
  code
end

Inconsistent indentation detected.
Open

  def destroy
      if ( is_principal? )
          @subject = Subject.find(params[:id])
          @subject.destroy
            flash[:alert] = "Matéria excluída com sucesso"
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

  def show_subjects
    @classroom = Classroom.find(params[:id])
    @subjects = @classroom.subject
  end
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Use 2 (not 1) spaces for indentation.
Open

          @subjects = Subject.all
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 1) spaces for indentation.
Open

        @classroom = Classroom.find(params[:id])
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 1) spaces for indentation.
Open

      if ( is_principal? )
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 1) spaces for indentation.
Open

          @subject = Subject.find(params[:id])
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 0) spaces for indentation.
Open

                    flash[:notice] = "Matéria alterada com sucesso"
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 1) spaces for indentation.
Open

                flash[:alert] = "Matéria não pode ser adicionada ou já existe na turma"
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Tab detected.
Open

    def classroom_subjects
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Tab detected.
Open

            @classroom_grades = ClassroomGrade.all
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Tab detected.
Open

            if ( @teacher.nil? )
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Tab detected.
Open

          @subject.destroy
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop
Severity
Category
Status
Source
Language