Sign upLogin

fga-gpp-mds/2017.1-Escola-X

View on GitHub
Star

Showing 3,213 of 3,213 total issues

Inconsistent indentation detected.
Open

  def index
      if ( is_principal? or is_teacher? )
          @subjects = Subject.all
    else
      redirect_to "/errors/error_500"
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Tab detected.
Open

          redirect_to subjects_path
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Space inside parentheses detected.
Open

      if ( is_principal? )
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      relations = ClassroomSubject.where("subject_id = ?", subject.id)
Severity: Minor
Found in app/controllers/teachers_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Align else with if.
Open

    else
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cops checks the alignment of else keywords. Normally they should be aligned with an if/unless/while/until/begin/def keyword, but there are special cases when they should follow the same rules as the alignment of end.

Example:

# bad
if something
  code
 else
  code
end

# bad
if something
  code
 elsif something
  code
end

# good
if something
  code
else
  code
end

Space inside parentheses detected.
Open

      if ( is_principal? )
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Align else with if.
Open

    else
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cops checks the alignment of else keywords. Normally they should be aligned with an if/unless/while/until/begin/def keyword, but there are special cases when they should follow the same rules as the alignment of end.

Example:

# bad
if something
  code
 else
  code
end

# bad
if something
  code
 elsif something
  code
end

# good
if something
  code
else
  code
end

Space inside parentheses detected.
Open

      if ( is_principal? )
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Use 2 (not 1) spaces for indentation.
Open

      if ( is_principal? or is_teacher? )
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Tab detected.
Open

          @subjects = Subject.all
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Space inside parentheses detected.
Open

      if ( is_principal? )
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Tab detected.
Open

            else
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Space inside parentheses detected.
Open

            if ( @teacher.nil? )
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Tab detected.
Open

                @subject.teacher_id = @teacher.id
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Tab detected.
Open

      end
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Tab detected.
Open

                render 'edit'
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Tab detected.
Open

                render 'new'
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Tab detected.
Open

                    flash[:notice] = "Matéria alterada com sucesso"
Severity: Minor
Found in app/controllers/subjects_controller.rb by rubocop

Space inside parentheses detected.
Open

    if ( logged_in? )
Severity: Minor
Found in app/controllers/notifications_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)

Space inside parentheses detected.
Open

    if ( is_employee? )
Severity: Minor
Found in app/controllers/notifications_controller.rb by rubocop

Checks for spaces inside ordinary round parentheses.

Example:

# bad
f( 3)
g = (a + 3 )

# good
f(3)
g = (a + 3)
Severity
Category
Status
Source
Language