Sign upLogin

fga-gpp-mds/2017.1-OndeE-UnB

View on GitHub
Star
darcyWeb/app/controllers/map/search_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method has too many lines. [34/25]
Open

  def geo(features)
    geo_json = []
    features.each do |feature|

      title = ''
Severity: Minor
Found in darcyWeb/app/controllers/map/search_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for geo is too high. [20.62/15]
Open

  def geo(features)
    geo_json = []
    features.each do |feature|

      title = ''
Severity: Minor
Found in darcyWeb/app/controllers/map/search_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method geo has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def geo(features)
    geo_json = []
    features.each do |feature|

      title = ''
Severity: Minor
Found in darcyWeb/app/controllers/map/search_controller.rb - About 1 hr to fix

    Block has too many lines. [26/25]
    Open

        features.each do |feature|

      title = ''
      description = ''
      image = ''
    Severity: Minor
    Found in darcyWeb/app/controllers/map/search_controller.rb by rubocop

    This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

    Extra empty line detected at block body beginning.
    Open

    
      title = ''
    Severity: Minor
    Found in darcyWeb/app/controllers/map/search_controller.rb by rubocop

    This cops checks if empty lines around the bodies of blocks match the configuration.

    Example: EnforcedStyle: empty_lines

    # good

foo do |bar|

  # ...

end

    Example: EnforcedStyle: noemptylines (default)

    # good

foo do |bar|
  # ...
end

    Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
    Open

         type: 'FeatureCollection',
    Severity: Minor
    Found in darcyWeb/app/controllers/map/search_controller.rb by rubocop

    This cops checks the indentation of the first key in a hash literal where the opening brace and the first key are on separate lines. The other keys' indentations are handled by the AlignHash cop.

    By default, Hash literals that are arguments in a method call with parentheses, and where the opening curly brace of the hash is on the same line as the opening parenthesis of the method call, shall have their first key indented one step (two spaces) more than the position inside the opening parenthesis.

    Other hash literals shall have their first key indented one step more than the start of the line where the opening curly brace is.

    This default style is called 'specialinsideparentheses'. Alternative styles are 'consistent' and 'align_braces'. Here are examples:

    Example: EnforcedStyle: specialinsideparentheses (default)

    # The `special_inside_parentheses` style enforces that the first key
# in a hash literal where the opening brace and the first key are on
# separate lines is indented one step (two spaces) more than the
# position inside the opening parentheses.

# bad
hash = {
  key: :value
}
and_in_a_method_call({
  no: :difference
                     })

# good
special_inside_parentheses
hash = {
  key: :value
}
but_in_a_method_call({
                       its_like: :this
                     })

    Example: EnforcedStyle: consistent

    # The `consistent` style enforces that the first key in a hash
# literal where the opening brace and the first key are on
# seprate lines is indented the same as a hash literal which is not
# defined inside a method call.

# bad
hash = {
  key: :value
}
but_in_a_method_call({
                       its_like: :this
                      })

# good
hash = {
  key: :value
}
and_in_a_method_call({
  no: :difference
})

    Example: EnforcedStyle: align_braces

    # The `align_brackets` style enforces that the opening and closing
# braces are indented to the same position.

# bad
and_now_for_something = {
                          completely: :different
}

# good
and_now_for_something = {
                          completely: :different
                        }

    There are no issues that match your filters.

    Category
    Status