Sign upLogin

fga-gpp-mds/2017.1-OndeE-UnB

View on GitHub
Star

Showing 364 of 364 total issues

Assignment Branch Condition size for departments is too high. [18.41/15]
Open

  def departments
    require 'nokogiri'
    require 'open-uri'
    html = open('https://matriculaweb.unb.br/graduacao/oferta_dep.aspx?cod=1')
    html_tree = Nokogiri::HTML(html, nil, Encoding::UTF_8.to_s)
Severity: Minor
Found in darcyWeb/app/controllers/parser_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Cyclomatic complexity for set_day_of_week is too high. [8/5]
Open

  def set_day_of_week(day_of_week)
    case day_of_week
    when 'Segunda'
      :monday
    when 'Terça'
Severity: Minor
Found in darcyWeb/app/controllers/parser_controller.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Assignment Branch Condition size for courses is too high. [17.09/15]
Open

  def courses
    require 'nokogiri'
    require 'open-uri'

    courses = []
Severity: Minor
Found in darcyWeb/app/controllers/parser_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for options_for_levels_with_plans is too high. [16.61/15]
Open

  def options_for_levels_with_plans(plans, building, selected_level)
    options = []
    plans.each do |plan|
      display = "#{plan.building.acronym} - Nível #{plan.level}"
      selected = false
Severity: Minor
Found in darcyWeb/app/helpers/admin_helper.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Cyclomatic complexity for valid_schedule_and_room? is too high. [6/5]
Open

  def valid_schedule_and_room?(day_of_week, start_time, end_time, room, classroom)
    valid_times = day_of_week.present? && start_time.present? && end_time.present?
    valid_room = room.present? && (room != 'Local a Designar') && classroom.present?
    valid_times && valid_room
  end
Severity: Minor
Found in darcyWeb/app/controllers/parser_controller.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method schedules has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def schedules
    require 'nokogiri'
    require 'open-uri'

    courses.each do |course|
Severity: Minor
Found in darcyWeb/app/controllers/parser_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function loadRouteForm has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function loadRouteForm(data) {

  $("#sidebar").load("/map/routes", function() {

    $(".btn-reverse-route").on("click", function(e) {
Severity: Minor
Found in darcyWeb/app/assets/javascripts/map/routes/index.js - About 1 hr to fix

    Method schedules has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def schedules
    require 'nokogiri'
    require 'open-uri'

    courses.each do |course|
    Severity: Minor
    Found in darcyWeb/app/controllers/parser_controller.rb - About 1 hr to fix

      Method geo has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def geo(features)
    geo_json = []
    features.each do |feature|

      title = ''
      Severity: Minor
      Found in darcyWeb/app/controllers/map/search_controller.rb - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            waypoint.marker = L.marker(latlng, {
      icon: L.AwesomeMarkers.icon({
        prefix: "ion",
        icon: waypoint.icon,
        markerColor: waypoint.color
        Severity: Major
        Found in darcyWeb/app/assets/javascripts/map/share_location.js and 1 other location - About 1 hr to fix
        darcyWeb/app/assets/javascripts/map/routes/map.js on lines 40..46

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          waypoint.marker = L.marker(latlng, {
    icon: L.AwesomeMarkers.icon({
      prefix: "ion",
      icon: waypoint.icon,
      markerColor: waypoint.color
        Severity: Major
        Found in darcyWeb/app/assets/javascripts/map/routes/map.js and 1 other location - About 1 hr to fix
        darcyWeb/app/assets/javascripts/map/share_location.js on lines 83..89

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          } else if (RouteObj.destination.marker !== null && RouteObj.origin.marker === null) {
    console.info("Origin in blank");
    MapObj.createMarker(RouteObj.origin, RouteObj.destination.marker.getLatLng());
    MapObj.removeMarker(RouteObj.destination);
  }
        Severity: Major
        Found in darcyWeb/app/assets/javascripts/map/routes/index.js and 1 other location - About 1 hr to fix
        darcyWeb/app/assets/javascripts/map/routes/index.js on lines 290..298

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          if (RouteObj.origin.marker !== null && RouteObj.destination.marker === null) {
    console.info("Destination in blank.");
    MapObj.createMarker(RouteObj.destination, RouteObj.origin.marker.getLatLng());
    MapObj.removeMarker(RouteObj.origin);
  } else if (RouteObj.destination.marker !== null && RouteObj.origin.marker === null) {
        Severity: Major
        Found in darcyWeb/app/assets/javascripts/map/routes/index.js and 1 other location - About 1 hr to fix
        darcyWeb/app/assets/javascripts/map/routes/index.js on lines 294..298

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function color has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const roomColor = function color(type) {
  var color = "#3F51B5";
  switch (type) {
    case "classroom":
      color = "#2196F3";
        Severity: Minor
        Found in darcyWeb/app/assets/javascripts/map/data/rooms.js - About 1 hr to fix

          Function Map has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function Map() {
  // enable and set options to the contextmenu
  map.contextmenu.enable();
  map.contextmenu.addItem({
    text: "Rotas a partir daqui",
          Severity: Minor
          Found in darcyWeb/app/assets/javascripts/map/routes/map.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              drawControl.disableDrawing = function disableDrawing(options) {
    if (drawnLayer.getLayers().length > 0) {
      drawControl.update(options);
    }
  }
            Severity: Major
            Found in darcyWeb/app/assets/javascripts/admin/locations.js and 1 other location - About 1 hr to fix
            darcyWeb/app/assets/javascripts/admin/locations.js on lines 23..27

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              drawControl.enableDrawing = function enableDrawing(options) {
    if (drawnLayer.getLayers().length == 0) {
      drawControl.update(options);
    }
  }
            Severity: Major
            Found in darcyWeb/app/assets/javascripts/admin/locations.js and 1 other location - About 1 hr to fix
            darcyWeb/app/assets/javascripts/admin/locations.js on lines 30..34

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Block has too many lines. [32/25]
            Open

                courses.each do |course|
      html = open(course[:url])
      html_tree = Nokogiri::HTML(html, nil, Encoding::UTF_8.to_s)
      schedules_rows = html_tree.css('.framecinza tr')
            Severity: Minor
            Found in darcyWeb/app/controllers/parser_controller.rb by rubocop

            This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            $(".leaflet-bar.easy-button-container.leaflet-control").eq(1)
  .attr("data-intro",
  "<h2>FIM!</h2> Chegamos ao fim! Caso tenha alguma <b>dúvida</b> ou queira ver o tutorial denovo clique nesse <b>botão</b>")
  .attr("data-step", "7")
  .attr("data-tooltipClass", "tutorialStyle")
            Severity: Minor
            Found in darcyWeb/app/assets/javascripts/map/tutorial.js and 1 other location - About 50 mins to fix
            darcyWeb/app/assets/javascripts/map/tutorial.js on lines 32..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            $(".leaflet-bar.easy-button-container.leaflet-control").eq(0)
  .attr("data-intro",
  "<h2>ROTAS</h2> Clicando nesse botão e inserindo o <b>Local de Partida</b> e o <b>Local de chegada</b>, uma rota será traçada e você vai conseguir navegar pela universidade sem nenhum problema!")
  .attr("data-step", "4")
  .attr("data-tooltipClass", "tutorialStyle")
            Severity: Minor
            Found in darcyWeb/app/assets/javascripts/map/tutorial.js and 1 other location - About 50 mins to fix
            darcyWeb/app/assets/javascripts/map/tutorial.js on lines 50..55

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language