Sign upLogin

fidilly/php-project-lvl2

View on GitHub
Star

Showing 8 of 8 total issues

Method makeDiffAst has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function makeDiffAst($contentBeforeChange, $contentAfterChange)
{
    $allKeys = union(array_keys($contentBeforeChange), array_keys($contentAfterChange));
    $makeDiff = function ($acc, $key) use ($contentBeforeChange, $contentAfterChange) {
        if (array_key_exists($key, $contentBeforeChange) && !array_key_exists($key, $contentAfterChange)) {
Severity: Minor
Found in src/MakeDiffAst.php - About 1 hr to fix

    Method render has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function render($ast, $depth = 0)
{
    $tabs = str_repeat('    ', $depth);
    $composeText = array_reduce($ast, function ($acc, $item) use ($tabs, $depth) {
        $key = $item['key'];
    Severity: Minor
    Found in src/Renderers/pretty.php - About 1 hr to fix

      Function makeDiffAst has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      function makeDiffAst($contentBeforeChange, $contentAfterChange)
{
    $allKeys = union(array_keys($contentBeforeChange), array_keys($contentAfterChange));
    $makeDiff = function ($acc, $key) use ($contentBeforeChange, $contentAfterChange) {
        if (array_key_exists($key, $contentBeforeChange) && !array_key_exists($key, $contentAfterChange)) {
      Severity: Minor
      Found in src/MakeDiffAst.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return $acc;
      Severity: Major
      Found in src/Renderers/pretty.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return $diffAst;
        Severity: Major
        Found in src/MakeDiffAst.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return implode($composeText, "\n") . "\n$tabs}";
          Severity: Major
          Found in src/Renderers/pretty.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                return implode($composeText, "\n");
            Severity: Major
            Found in src/Renderers/plain.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return $acc;
              Severity: Major
              Found in src/Renderers/plain.php - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language