Sign upLogin

fiedl/your_platform

View on GitHub
Star
app/models/ability.rb

Summary

Maintainability
F
3 days
Test Coverage

File ability.rb has 401 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Ability
  include CanCan::Ability

  def ability_classes
    [
Severity: Minor
Found in app/models/ability.rb - About 5 hrs to fix

    Method initialize has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

      def initialize(user, options = {})
    # Define abilities for the passed in user here. For example:
    #
    #   user ||= User.new # guest user (not logged in)
    #   if user.admin?
    Severity: Minor
    Found in app/models/ability.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method rights_for_signed_in_users has 84 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def rights_for_signed_in_users
    can :read, :terms_of_use
    can :accept, :terms_of_use if not read_only_mode?
    can :use, :single_sign_on
    Severity: Major
    Found in app/models/ability.rb - About 3 hrs to fix

      Consider simplifying this complex logical expression.
      Open

          if not read_only_mode?
      # Local officers can create events in their groups.
      #
      can :create, Event
      can [:create_event, :create_event_for], Group do |group|
      Severity: Critical
      Found in app/models/ability.rb - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

            if not read_only_mode?
      # Jeder muss Dokumente erstellen können, z.B. um Konventsprotokolle hochzuladen.
      # Ansonsten würden auch Verteilermails mit Dokumenten fehlschlagen.
      can :create, Document
        Severity: Critical
        Found in app/models/ability.rb - About 2 hrs to fix

          Method rights_for_local_officers has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def rights_for_local_officers
    can :export_member_list, Group do |group|
      user.in? group.officers_of_self_and_ancestors
    end
          Severity: Major
          Found in app/models/ability.rb - About 2 hrs to fix

            Class Ability has 21 methods (exceeds 20 allowed). Consider refactoring.
            Open

            class Ability
  include CanCan::Ability

  def ability_classes
    [
            Severity: Minor
            Found in app/models/ability.rb - About 2 hrs to fix

              Method rights_for_everyone has 51 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def rights_for_everyone

    # Feature switches
    #
    can :use, :semester_calendars
              Severity: Major
              Found in app/models/ability.rb - About 2 hrs to fix

                Method initialize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def initialize(user, options = {})
    # Define abilities for the passed in user here. For example:
    #
    #   user ||= User.new # guest user (not logged in)
    #   if user.admin?
                Severity: Minor
                Found in app/models/ability.rb - About 1 hr to fix

                  Method rights_for_signed_in_users has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def rights_for_signed_in_users
    can :read, :terms_of_use
    can :accept, :terms_of_use if not read_only_mode?
    can :use, :single_sign_on
                  Severity: Minor
                  Found in app/models/ability.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method rights_for_local_officers has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def rights_for_local_officers
    can :export_member_list, Group do |group|
      user.in? group.officers_of_self_and_ancestors
    end
                  Severity: Minor
                  Found in app/models/ability.rb - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method rights_for_everyone has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def rights_for_everyone

    # Feature switches
    #
    can :use, :semester_calendars
                  Severity: Minor
                  Found in app/models/ability.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                    def rights_for_dummy_users
    can :read, :terms_of_use
    can :accept, :terms_of_use if not read_only_mode?

    can :read, User do |user|  # Only read other dummy users.
                  Severity: Major
                  Found in app/models/ability.rb and 1 other location - About 1 hr to fix
                  app/models/abilities/dummy_ability.rb on lines 6..28

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 53.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status