app/models/concerns/group_memberships.rb
Method members=
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
Open
def members=(new_members)
for member in self.direct_members
unassign_user member unless member.in? new_members if member
end
for new_member in new_members
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method assign_user
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
Open
def assign_user(user, options = {})
raise RuntimeError, "no user given" if not user
time_of_joining = options[:joined_at] || options[:at] || options[:time] || Time.zone.now
if m = Membership.with_past.find_by_user_and_group(user, self)
m.valid_from = time_of_joining if m.valid_from && time_of_joining < m.valid_from
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"